Closed
Bug 589155
Opened 14 years ago
Closed 14 years ago
[Firefox Button]Missing items in Bookmarks popup if Bookmarks Menu Widget has been removed from toolbar
Categories
(Firefox :: Menus, defect)
Tracking
()
RESOLVED
FIXED
Firefox 4.0
Tracking | Status | |
---|---|---|
blocking2.0 | --- | final+ |
People
(Reporter: alice0775, Unassigned)
References
Details
(Keywords: regression, Whiteboard: [fixed in bug 592900])
Attachments
(2 files)
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre)
Gecko/20100819 Minefield/4.0b5pre ID:20100820033948
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre)
Gecko/20100819 Minefield/4.0b5pre ID:20100820033948
Missing items in Bookmarks popup.
If Bookmarks Toolbar is shown and no Bookmarks Widget in the toolbar.
Reproducible: Always
Steps to Reproduce:
1. Start Minefield with new profile
2. Show "Bookmarks Toolbar" (Alt > View > Toolbars > Check "Bookmarks Toolbar")
3. Customize Toolbar and remove "Booknarks Button Widget" from toolbar
(Alt > View > Toolbars > Customize... , Drag & drop Bookmarks into palette)
4. Open Bookmarks popup
(Click Firefox Button , "Bookmarks >")
Actual Results:
Missing items in Bookmarks popup.
Expected Results:
The bookmark should be at the position of the indicator
Reporter | ||
Comment 1•14 years ago
|
||
Sorry,I made wrong description.
>Expected Results:
> The bookmark should be at the position of the indicator
Corrected description is as follows;
Expected Results:
All bookmarks should be appears in the popup.
Reporter | ||
Comment 2•14 years ago
|
||
I addition to comment #0,
After Step 4,
Error: viewToolbar is null
Source file: chrome://browser/content/browser.js
Line: 2555
let viewToolbar = document.getElementById("BMB_viewBookmarksToolbar");
if (!this._popupInitialized) {
// First popupshowing event, initialize immutable attributes.
this._popupInitialized = true;
// Update View bookmarks toolbar checkbox menuitem.
>> viewToolbar.setAttribute("toolbarindex",
Array.indexOf(gNavToolbox.childNodes,
this.personalToolbar));
Comment 3•14 years ago
|
||
Can't seem to reproduce this.
Reporter | ||
Comment 4•14 years ago
|
||
In my case, reproduced 100%.
Steps to Reproduce:
1. Start Minefield with new profile
2. Customize Toolbar and remove "Bookmarks Button Widget" from toolbar
(Alt > View > Toolbars > Customize... , Drag & drop Bookmarks Button Widget into palette)
3. Close dialog (Done)
4. Open Bookmarks menu popup
(Click Firefox Button , "Bookmarks >")
Actual Results:
Missing items in Bookmarks popup, even if browser restarted.
Summary: [Firefox Menu Button]Missing items in Bookmarks popup → [Firefox Menu Button]Missing items in Bookmarks popup if Bookmarks Menu Widget fas beenis removed from toolbar
Reporter | ||
Updated•14 years ago
|
Summary: [Firefox Menu Button]Missing items in Bookmarks popup if Bookmarks Menu Widget fas beenis removed from toolbar → [Firefox Menu Button]Missing items in Bookmarks popup if Bookmarks Menu Widget has beenis removed from toolbar
Reporter | ||
Updated•14 years ago
|
Summary: [Firefox Menu Button]Missing items in Bookmarks popup if Bookmarks Menu Widget has beenis removed from toolbar → [Firefox Menu Button]Missing items in Bookmarks popup if Bookmarks Menu Widget has been removed from toolbar
Reporter | ||
Updated•14 years ago
|
Summary: [Firefox Menu Button]Missing items in Bookmarks popup if Bookmarks Menu Widget has been removed from toolbar → [Firefox Button]Missing items in Bookmarks popup if Bookmarks Menu Widget has been removed from toolbar
Target Milestone: --- → Firefox 4.0
Comment 6•14 years ago
|
||
I encountered this and got steps to reproduce, then found this bug had already been filed (thanks to Alice). Here's the dodgy code before it gets included into browser.js:
http://hg.mozilla.org/mozilla-central/annotate/e14130b81b5f/browser/base/content/browser-places.js#l1152
Comment 7•14 years ago
|
||
the code was added before the button was made removable.
Updated•14 years ago
|
Blocks: 560198
Keywords: regression
Updated•14 years ago
|
blocking2.0: --- → final+
Comment 10•14 years ago
|
||
Joshua M , can you now reproduce it as demonstrated in the video ?
Comment 11•14 years ago
|
||
(In reply to comment #10)
> Joshua M , can you now reproduce it as demonstrated in the video ?
This happened to me randomly today. Not sure of a fix right now.
Comment 12•14 years ago
|
||
As far as i have noticed , it occurs for once after each fresh start. Just restart , hover mouse , u see old list , then hover again , u get all ur bookmarks . And then it would seem that its fixed
but when u restart , the same happens for first time , and then fixed
Comment 13•14 years ago
|
||
Ok , i found out that it occurs with all new windows , so i presume , it has something to do with chrome loading(?)
Steps to Reproduce :
1.Open Firefox
2.Click Menu Button > However on the list next to "Bookmarks"
3.Wait and watch , you See
Separator
Unsorted Bookmarks
Show All bookmarks
Separator
Bookmark This page
Subscribe to this page
Separator
4.Click somewhere else , and repeat till step 3 , you see
Show All bookmarks
Separator
Bookmark This page
Subscribe to this page
[YOUR BOOKMARKS IN MENU , IF ANY]
Separator
Unsorted Bookmarks
This happens with each new window and for the first time , once u see the step 4 , it won't reoccur - AT LEAST ON THAT WINDOW
Comment 14•14 years ago
|
||
However*=hover
sorry :|
Comment 15•14 years ago
|
||
I suspect some or all of this stuff will be fixed by my patch in bug 592900
Updated•14 years ago
|
No longer blocks: FirefoxButton
Comment 17•14 years ago
|
||
working fine after patch for bug 592900, reopen if you notice remaining issues regarding this.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in bug 592900]
You need to log in
before you can comment on or make changes to this bug.
Description
•