Closed Bug 58959 Opened 24 years ago Closed 24 years ago

xpti does not correctly handle an interface name change.

Categories

(Core :: XPCOM, defect, P3)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: jband_mozilla, Assigned: jband_mozilla)

Details

Attachments

(1 file)

The xpti (InterfaceInfo or Typelib reading) system has an AutoReg system that deals with detecting changes in .xpt files and .xpt in .zip files at startup (in debug builds). It fails to correctly handle the case where an interface descriptor has had only its name change. Developers sometimes do this as they change their code. If the iid changes or the interface descriptor is moved from one file to another then the change is detected and all is well. If only an interface name changes then the change is reflected into the type manifest (xpti.dat) and the *following* run of the app will see the change, but the current run will not. I have a patch.
Attached patch proposed fix (deleted) — Splinter Review
The bottom of the attached patch fixes this problem. The rest of the patch incorporates a part of the fix for bug 57370. This is a simple added method to allow us to compare iids on interfaceinfos without having to copy them from a getter call for compare. This is small and safe and I think it is better to get this in now rather than to fiddle my tree to remove the change.
fix checked in.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: