Closed
Bug 589742
Opened 14 years ago
Closed 14 years ago
GLOBAL_VARS from localconfig.py should override the same variable from config.py
Categories
(Release Engineering :: General, defect, P2)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: rail)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
catlee
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
At the moment there is no possibility to redefine GLOBAL_VARS dictionary variables within localconfig.py. The only way to do this is to move the corresponding variable to {production,preproduction,staging}_config.py.
Configuration of masters will be more flexible if we allow localconfig.py override config.py.
Please review the attached patch.
Attachment #468259 -
Flags: review?(catlee)
|
Assignee | |
Comment 1•14 years ago
|
||
BTW, "python config.py" command gives me the same output before and after the patch (tested for {production,preproduction,staging}_config.py linked to localconfig.py). Redefining a variable in localconfig.py works as well.
|
|
Assignee | |
Comment 2•14 years ago
|
||
typo fix
Attachment #468259 -
Attachment is obsolete: true
Attachment #468262 -
Flags: review?(catlee)
Attachment #468259 -
Flags: review?(catlee)
|
||
Updated•14 years ago
|
Attachment #468262 -
Flags: review?(catlee) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Comment on attachment 468262 [details] [diff] [review]
localconfig.py should override config.py
http://hg.mozilla.org/build/buildbot-configs/rev/ce6a4f012ec5
Attachment #468262 -
Flags: checked-in+
|
|
Assignee | |
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•