Closed
Bug 592677
Opened 14 years ago
Closed 14 years ago
(Tabs On Bottom) Increase space between Bookmarks bar and Navigation bar
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 4.0b8
People
(Reporter: Terepin, Assigned: dao)
References
()
Details
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
Gavin
:
review+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
No Padding Between Toolbars
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100901 Firefox/4.0b6pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100901 Firefox/4.0b6pre
Current nav buttons are too close to Bookmarks bar.
Reproducible: Always
|
Reporter | |
Updated•14 years ago
|
|
||
Comment 1•14 years ago
|
||
shorlander - another one for your input
|
||
Comment 2•14 years ago
|
||
(In reply to comment #1)
> shorlander - another one for your input
This should block. It looks broken right now because there isn't any space between them. Adding some bottom padding to the navigation bar is probably fairly easy.
Assignee: nobody → shorlander
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
|
||
Updated•14 years ago
|
blocking2.0: ? → final+
|
Assignee | |
Comment 3•14 years ago
|
||
Tweaked some selectors while I was at it. browser.js sets the inFullscreen attribute on all fullscreen toolbars.
Assignee: shorlander → dao
Attachment #491179 -
Flags: review?(gavin.sharp)
|
||
Comment 4•14 years ago
|
||
It it just a mistake that you're removing the :not([inFullscreen="true"]) for the #PersonalToolbar border-radius rules?
blocking2.0: final+ → ---
OS: Windows 7 → All
|
|
Assignee | |
Comment 5•14 years ago
|
||
#PersonalToolbar won't have that attribute since it lacks fullscreentoolbar="true".
|
|
Assignee | |
Updated•14 years ago
|
OS: All → Windows 7
|
|
||
Updated•14 years ago
|
Attachment #491179 -
Flags: review?(gavin.sharp)
Attachment #491179 -
Flags: review+
Attachment #491179 -
Flags: approval2.0+
|
|
Assignee | |
Comment 6•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
You need to log in
before you can comment on or make changes to this bug.
Description
•