Closed Bug 593321 Opened 14 years ago Closed 13 years ago

Opening saved .EML with empty subject has wrong window title

Categories

(Thunderbird :: Message Reader UI, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 12.0

People

(Reporter: nONoNonO, Assigned: hiro)

References

Details

(Keywords: regression, testcase)

Attachments

(3 files, 1 obsolete file)

Attached file Test message with empty subject line (deleted) —
When you save a message with an empty subject line and open it again by double clicking the file, you get a window with "nullMozilla Thunderbird" as title. When you view the same message from within Thunderbird, you only see "Thunderbird" as title. Steps to Reproduce: 1. Compose a message with an empty subject line and send it to yourself 2. View the message in a new window in thunderbird and verify the window title is "Mozilla Thunderbird" 3. Save the message as a file 4. Open the saved file and see the window title is now "nullMozilla Thunderbird" The subject displayed in the window title should be the same as when viewed from within Thunderbird, so without the null part.
Onno is this a regression ?
Keywords: testcase
In Thunderbird 2 the subject is initialized and the title is shown as "- Thunderbird". In TB3.0.6 also the wrong "nullMozilla Thunderbird" is shown, so yes, it's a regression, but for version 3.0.
(In reply to comment #2) > In Thunderbird 2 the subject is initialized and the title is shown as "- Can you try to figure out when this broke ?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
I cannot seem to find old releases of 3.0.1 or nightlies of around that version on http://ftp.mozilla.org/pub/mozilla.org/thunderbird/ :-( Oldest version is 3.0.4...
This has been bOrken since TB3.0b3. In alpha versions and earlier beta versions the opening of .EML files doesn't work at all...
(In reply to comment #5) > This has been bOrken since TB3.0b3. In alpha versions and earlier beta versions > the opening of .EML files doesn't work at all... Can you try to get a date range for that ?
date situation 2009-06-28 does not launch thunderbird on double click 2009-06-29 shows "null - Shredder" as windows title ... 2009-07-06 shows "null - Shredder" as windows title 2009-07-07 shows "nullShredder" as windows title
2009-06-27 works ?
No, before 2009-06-28 window doesn't open on double click...
> 2009-07-06 shows "null - Shredder" as windows title > 2009-07-07 shows "nullShredder" as windows title regression range points to this Bug 502389 - Thunderbird should make use of titlemodifier and titlemenuseparator attributes on the main and message windows - see http://hg.mozilla.org/comm-central/pushloghtml?startdate=2009-07-06&enddate=2009-07-07
Blocks: 502389
Severity: normal → minor
Attached patch fix (deleted) — Splinter Review
Attachment #589034 - Flags: review?(dbienvenu)
Attached patch Tests (obsolete) (deleted) — Splinter Review
Assignee: nobody → hiikezoe
Status: NEW → ASSIGNED
Attachment #589362 - Flags: review?(dbienvenu)
OS: Windows 7 → All
Hardware: x86 → All
Please use MPL2 - http://www.mozilla.org/MPL/headers/ Also, can you add file documentation /** * Tests that opening an .eml file with emtpy subject works. */ header like ^^ to the test? That way dir listings with mxr are useful.
Comment on attachment 589034 [details] [diff] [review] fix thx, Hiro!
Attachment #589034 - Flags: review?(dbienvenu) → review+
Comment on attachment 589362 [details] [diff] [review] Tests thx, Hiro, r=me, with a couple nits: 2012 copyright year and + let expectedTitle; + if (subject) + expectedTitle = subject + " - " + productName; + else + expectedTitle = productName; + this can be just let expectedTitle = (subject) ? subject + " - " + productName : productName;
Attachment #589362 - Flags: review?(dbienvenu) → review+
Attached patch Revised test file (deleted) — Splinter Review
Carrying over review +. Switch to MPL2, add comment about the test and use ternary operator.
Attachment #589362 - Attachment is obsolete: true
Attachment #591345 - Flags: review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Depends on: 721071
Depends on: 738451
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: