Closed Bug 59796 Opened 24 years ago Closed 13 years ago

ParsePluginMimeDescription() fails to check for malloc failure

Categories

(Core Graveyard :: Plug-ins, defect, P3)

x86
Linux
defect

Tracking

(Not tracked)

RESOLVED INVALID
Future

People

(Reporter: dbaron, Assigned: srgchrpv)

Details

(Keywords: helpwanted, Whiteboard: [PL2:NA])

Attachments

(1 file)

In bug 59159, referring to nsPluginsDirUnix.cpp, brendan@mozilla.org wrote: av: nsPluginFile:GetPluginInfo fails to check for malloc failure, and will crash hard on null pointers if malloc does fail. How about a patch? Filing this bug to track the issue.
Moving to m0.9.1 and reassigning to peterl.
Assignee: av → peterl
Target Milestone: --- → mozilla0.9.1
Status: NEW → ASSIGNED
Keywords: helpwanted
Target Milestone: mozilla0.9.1 → Future
Shouldn't this bug be closed, as there's no more malloc's in GetPluginInfo ?
those mallocs moved into ParsePluginMimeDescription() http://lxr.mozilla.org/mozilla/source/modules/plugin/base/src/nsPluginsDirUnix.c pp#122 I'm changing the summary and reassign myself
Assignee: peterl → serge
Status: ASSIGNED → NEW
Summary: nsPluginFile:GetPluginInfo fails to check for malloc failure → ParsePluginMimeDescription() fails to check for malloc failure
Attached patch straightforward fix :-) (deleted) — Splinter Review
Keywords: patch, review
removing myself from cc:
Whiteboard: [PL2:NA]
Target Milestone: Future → mozilla1.0.2
Target Milestone: mozilla1.0.2 → mozilla1.2alpha
Target Milestone: mozilla1.2alpha → mozilla1.3alpha
future
Target Milestone: mozilla1.3alpha → Future
QA Contact: shrir → plugins
This issue here no longer exists from what I can tell.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → INVALID
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: