Closed Bug 59888 Opened 24 years ago Closed 24 years ago

Mac filepicker titles are being used as captions instead

Categories

(Core :: XUL, defect, P3)

PowerPC
Mac System 8.5
defect

Tracking

()

RESOLVED FIXED
mozilla0.8

People

(Reporter: mpt, Assigned: danm.moz)

Details

Build: 2000111108, Mac OS 9.0 To reproduce: * In Navigator, choose `File' > `Open File ...' or `File' > `Save As ...'. * Look at the area above the help button.. What you see: * Text which is obviously meant to be the title of the window -- `Open File' and `Save File' respectively. What you should see: * This text should actually *be* the title of the window, and should not be used as the caption.
[Sorry, wrong component. --> XP Toolkit/Widgets.]
Assignee: pinkerton → trudelle
Component: XP Apps → XP Toolkit/Widgets
QA Contact: sairuh → jrgm
->danm
Assignee: trudelle → danm
I'm confused. I don't see Help buttons in the dialogs mentioned. What am I goofing on?
The Help button is the little square button with a `?' sign inside a circle, a the bottom left corner of the dialog. (There may not be one in the version of Navigation Services installed on your machine, I don't know.) Anyway, the problem text is near the lower left corner of the dialog.
No, I think the correct answer would have made liberal use of the word "mushrooms." But anyway, I see what you're talking about now. This patch fixes the problem. It's probably the right thing to do; the other platforms are using that string as a window title. Looks like the original author of this file just picked the wrong field in the parameter struct. Index: nsFilePicker.cpp =================================================================== RCS file: /cvsroot/mozilla/widget/src/mac/nsFilePicker.cpp,v retrieving revision 1.26 diff -r1.26 nsFilePicker.cpp 296c296 < ::BlockMoveData(inTitle, dialogOptions.message, *inTitle + 1); --- > ::BlockMoveData(inTitle, dialogOptions.windowTitle, *inTitle + 1); 369c369 < ::BlockMoveData(inTitle, dialogOptions.message, *inTitle + 1); --- > ::BlockMoveData(inTitle, dialogOptions.windowTitle, *inTitle + 1); 427c427 < ::BlockMoveData(inTitle, dialogOptions.message, *inTitle + 1); --- > ::BlockMoveData(inTitle, dialogOptions.windowTitle, *inTitle + 1);
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.8
Looks innocent enough (famous last words). You'd think that with all the string code in this product, we'd be able to do this without resorting to BlockMoveData. But that's a story for another day. And I don't see any use of the word "mushroom," let alone liberal use of it. Tsk, tsk. r=pchen
.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.