Closed
Bug 603728
Opened 14 years ago
Closed 14 years ago
widget/src/gtk2/nsWindow.cpp:3123: warning: unused variable 'domVirtualKeyCode'
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b7
People
(Reporter: dholbert, Assigned: masayuki)
References
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
|
(deleted),
patch
|
karlt
:
review+
joe
:
approval2.0+
|
Details | Diff | Splinter Review |
> mozilla/widget/src/gtk2/nsWindow.cpp: In member function 'PRBool nsWindow::DispatchKeyDownEvent(GdkEventKey*, PRBool*)':
> mozilla/widget/src/gtk2/nsWindow.cpp:3123: warning: unused variable 'domVirtualKeyCode'
Here's the flagged line:
>3123 PRUint32 domVirtualKeyCode = GdkKeyCodeToDOMKeyCode(aEvent->keyval);
Looks like that line (including the function call) can just be removed... masayuki, is there any reason we need that?
|
Reporter | |
Comment 1•14 years ago
|
||
|
Assignee | |
Comment 2•14 years ago
|
||
Yes, we can remove it!
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #482768 -
Flags: review?(karlt)
|
||
Updated•14 years ago
|
Attachment #482768 -
Flags: review?(karlt) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Comment on attachment 482768 [details] [diff] [review]
Patch v1.0
no risk. fix a nit.
Attachment #482768 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #482768 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
|
||
Updated•14 years ago
|
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•