Closed Bug 60378 Opened 24 years ago Closed 3 years ago

unneeded style resolutions for list/select items.

Categories

(Core :: Layout: Form Controls, defect, P4)

defect

Tracking

()

RESOLVED INCOMPLETE
Future

People

(Reporter: buster, Assigned: john)

Details

(Keywords: perf)

This needs verification, but I think we do a bunch of unnecessary style resolution when we create frames for lists and combo boxes. The vast majority of the time (and in the real world as it exists today, very close to 100% of the time), items in lists have identical style. But we resolve style for each individually, just in case. This seems very wasteful. There should be some way we can detect that style for each is identical, and skip the resolution. Subsequent items could just grab their style context from the first. Alternately, could we shift the cost to the back end? Do the initial layout as if they have identical style, then scan to verify, and if it isn't true fire off a style changed reflow to the items that need it? Since Rod is looking at doing lazy instantiation of list contents, it's critical to make initial list layout very fast. We need some quantify numbers, but I'll bet style resolution is a major performance cost.
Keywords: perf
OS: Windows NT → All
Priority: P3 → P2
Hardware: PC → All
Status: NEW → ASSIGNED
I don't think they can share the style.
Target Milestone: --- → Future
QA Contact Update
QA Contact: bsharma → vladimire
Priority: P2 → P4
QA Contact: vladimire → tpreston
Isn't roc / dbaron working on that?
->
Assignee: rods → jkeiser
Status: ASSIGNED → NEW
This is a good time to do a select layout rewrite as well (one is sorely needed).
Status: NEW → ASSIGNED
Summary: unneeded style resolution → unneeded style resolutions for list/select items.
QA Contact: tpreston → layout.form-controls

Closing this as resolved:incomplete, there has been no activity on this issue in the last 19 years and the assignee has the account disabled as well. Please re-open it if this issue is still relevant today.

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.