Closed Bug 60406 Opened 24 years ago Closed 24 years ago

javascript error in charsetOverlay.js (line 126: wnd has no properties ) after turning off sidebar and toolbars

Categories

(Core :: Internationalization, defect, P3)

defect

Tracking

()

VERIFIED FIXED
mozilla0.9.1

People

(Reporter: matt, Assigned: jbetak)

References

()

Details

Attachments

(4 files)

1. start a fresh run of the browser 2. toggle View-->Toolbars-->Personal Toolbar off 3. toggle View-->Toolbars-->Taskbar off 4. toggle View-->My Sidebar off 5. Select View-->Character Coding-->Auto-detect Result: The following message is output: "JavaScript error: chrome://global/content/charsetOverlay.js line 126: wnd has no properties"
over to i18n Confirmed with build 111704 on NT
Assignee: asa → nhotta
Status: UNCONFIRMED → NEW
Component: Browser-General → Internationalization
Ever confirmed: true
QA Contact: doronr → teruko
Reassign to cata.
Assignee: nhotta → cata
To reproduce, just do: Select View-->Character Coding-->Auto-detect Off
move all cata's bug to ftang
Assignee: cata → ftang
shanjian- can you take a look at this ?
Assignee: ftang → shanjian
I could reproduce it yesterday, but not today after I update the source tree. I assume the bug was gone. Reopen the bug if you still see problem.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
I see this in 2001-03-01-10 Win32 with NT.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Changed QA contact to andreasb@netscape.com.
QA Contact: teruko → andreasb
Status: REOPENED → ASSIGNED
This problem is related with bug65963, most likely a duplicate. However, I have problem in reproducing any of those in my debug env.
jbetak- please take a look at it.
Assignee: shanjian → jbetak
Status: ASSIGNED → NEW
QA Contact: andreasb → jonrubin
essentially same issue as 67623
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: PC → All
Summary: JavaScript error (charsetOverlay.js line 126: wnd has no properties ) after turning off sidebar and toolbars → javascript error in charsetOverlay.js (line 126: wnd has no properties ) after turning off sidebar and toolbars
Target Milestone: --- → mozilla0.9.1
I was able to reproduce consistenly using build 2001032804. Creating a new profile while leaving all charset-related settings on their default value does the trick for me. Bugs 65963, 67623 and 60406 are all related. I'm hesitant to mark them as dups now. We might want to do so, when additional information becomes available.
another update on repro: the critical element seems to be "My Sidebar". 1) visit http://gemal1.sprawl.dk/ 2) turn on and off your sidebar 3) Tasks->Tools->JavaScript Console 3) View->Character Coding (get error in the JS Console) 4) View->Character Coding->Auto-Detect (get same error for different submenu in the JS Console) Please note that in 3) and 4) nothing will be selected from the menu. The error gets thrown when opening the respective submenus.
Hm, since I'm doing some related work on charsetOverlay.js for bug 74680 and bug 73881 and wanted to address this bug also and found that http://gemal1.sprawl.dk/ is no longer accessible. I'm looking into similar sites, it would really help me, if someone had an alternate test site. Gemal, are you still following this?
marking dependency on bug 73881 and bug 78290. If we moved the checkmark update code fully into RDF (nsCharsetMenu.cpp), we could retire the function UpdateCurrentCharset() in charsetOverlay.js. It would obviously also address this bug...
Depends on: 73881, 78290
adding a replacement URL for http://gemal1.sprawl.dk/ here are the updated repro steps: 1) visit http://webmail.redbox.cz/ 2) turn on and off your sidebar 3) Tasks->Tools->JavaScript Console 3) View->Character Coding (get error in the JS Console) 4) View->Character Coding->Auto-Detect (get same error for different submenu in the JS Console)
still present in the 20010501 build. Looks like the main browser window loses focus when the sidebar is turned on and off. When clicking the main window or its navigational elements it regains focus and the warning goes away. The previous comment on moving this functionality into nsCharsetMenu.cpp still applies.
I just created a patch - Naoki would you care to review? I'll try to get a sr and check the fix in this week. How is it with regressions - since we know that the function UpdateCurrentCharset() will go away, should we file a tracking bug for it? Gemal, are you still following this? What is your view?
Is that possible to call window._content.focus()?
The problem is that document.commandDispatcher.focusedWindow return a null, which seems odd to me. However, your comment made me try something less obvious. It seems to work much better; it actually updates the charset menu checkmark when the browser window is out of focus, instead of just avoiding the warning.
r=nhotta Do you still need "if (wnd)" (i.e. can "window._content" be null)?
alecf, would you care to do a painless sr for a change?
whee sr=alecf
And another one bites the dust... Thanks everyone!
Status: ASSIGNED → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → FIXED
Verified on: MacOS9.1 using 2001052405 WinMe-Ja using 2001052904 RH Linux7.0-Ja using 2001052205
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: