Closed Bug 60864 Opened 24 years ago Closed 17 years ago

Resized address toolbar does not collapse splitter properly

Categories

(MailNews Core :: Composition, defect, P3)

x86
Windows 95
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: polish)

Attachments

(5 files, 1 obsolete file)

Build ID: 2000112015 Steps to reproduce problem: 1. Create a new message. 2. Collapse the address toolbar. 3. Expand the address toolbar. 4. Adjust the splitter. 5. Collapse the address toolbar. Expected result: Address toolbar collapses properly both times. Actual result: Splitter does not collapse with the address toolbar.
QA Contact: esther → nbaca
Build 2000-11-21-04: Win95 I am unable to reproduce the problem. It appears that the entire address area is collapsed and I don't see the splitter. I've tried adjusting the splitter to make it wider or narrow with the same results. Any other suggestions for reproducing the problem?
Attached image Collapsed correctly (deleted) —
Attached image Collapsed incorrectly (deleted) —
Build 2000-11-28-09:Win96, Linux 6.0, Mac 9.04 I was able to reproduce this by adjusting the splitter that appears below the 'Formatting Toolbar'. When I initially reported that I could not reproduce the problem I was adjusting the splitter in the address area which is vertical to the Attachments area.
Sorry, I didn't realize that there were two splitters...
No problem, I'm just glad that I could reproduce the problem :-)
reassign to varada
Assignee: ducarroz → varada
Accepting bugs.
Status: NEW → ASSIGNED
Attached patch Proposed patch (deleted) — Splinter Review
Keywords: patch, polish, review, ui
taking all of varada's bugs.
Assignee: varada → sspitzer
Status: ASSIGNED → NEW
Attachment #89698 - Flags: review?(cavin)
Comment on attachment 89698 [details] [diff] [review] Proposed patch r=cavin.
Attachment #89698 - Flags: review?(cavin) → review+
Product: MailNews → Core
sorry for the spam. making bugzilla reflect reality as I'm not working on these bugs. filter on FOOBARCHEESE to remove these in bulk.
Assignee: sspitzer → nobody
resolved fixed?
Attached patch Updated patch, version 1 (deleted) — Splinter Review
We can alternatively fix this bug by moving the splitter inside the toolbar (this has recently been made possible on trunk using resizeafter="grow").
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #284934 - Flags: review?(mnyromyr)
Attached patch Updated patch, version 2 (obsolete) (deleted) — Splinter Review
Alternatively we could go for a revised version of my original patch; this patch also fixes an add/removeEventListener mismatch and hides the splitter when you collapse the addressing toolbar.
Attachment #284935 - Flags: review?(mnyromyr)
would this help with anything in Bug 290865 comment 3?
(In reply to comment #16) >would this help with anything in Bug 290865 comment 3? No, it's not; this only applies to the use of the toolbargrippy.
Comment on attachment 284934 [details] [diff] [review] Updated patch, version 1 Having the splitter right of the grippy looks just weird.
Attachment #284934 - Flags: review?(mnyromyr) → review-
Comment on attachment 284935 [details] [diff] [review] Updated patch, version 2 I prefer this approach, but is has issues: if you drag the splitter upwards, it will finally start to hide the subject row. If you drag on, it will even hide almost all of the address bar - but the listbox lines will shine through! And furthermore, if you let go of the splitter, it will jump back down to guarantee a minheight for the addressbar. So, either the splitter should really hide _all_ stuff and remain where it was dragged to or it shouldn't be draggable that far...
Attachment #284935 - Flags: review?(mnyromyr) → review-
Attached patch Includes CSS fix for comment 19 (deleted) — Splinter Review
The resizing issue appears to be due to the min-height in toolkit's toolbar.css
Attachment #284935 - Attachment is obsolete: true
Attachment #289791 - Flags: review?(mnyromyr)
Attachment #289791 - Flags: review?(mnyromyr) → review+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Product: Core → MailNews Core
Depends on: 514416
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: