Closed
Bug 60864
Opened 24 years ago
Closed 17 years ago
Resized address toolbar does not collapse splitter properly
Categories
(MailNews Core :: Composition, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
Details
(Keywords: polish)
Attachments
(5 files, 1 obsolete file)
(deleted),
image/gif
|
Details | |
(deleted),
image/gif
|
Details | |
(deleted),
patch
|
cavin
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mnyromyr
:
review-
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mnyromyr
:
review+
|
Details | Diff | Splinter Review |
Build ID: 2000112015
Steps to reproduce problem:
1. Create a new message.
2. Collapse the address toolbar.
3. Expand the address toolbar.
4. Adjust the splitter.
5. Collapse the address toolbar.
Expected result: Address toolbar collapses properly both times.
Actual result: Splitter does not collapse with the address toolbar.
Comment 1•24 years ago
|
||
Build 2000-11-21-04: Win95
I am unable to reproduce the problem. It appears that the entire address area is
collapsed and I don't see the splitter. I've tried adjusting the splitter to
make it wider or narrow with the same results. Any other suggestions for
reproducing the problem?
Assignee | ||
Comment 2•24 years ago
|
||
Assignee | ||
Comment 3•24 years ago
|
||
Comment 4•24 years ago
|
||
Build 2000-11-28-09:Win96, Linux 6.0, Mac 9.04
I was able to reproduce this by adjusting the splitter that appears below the
'Formatting Toolbar'.
When I initially reported that I could not reproduce the problem I was adjusting
the splitter in the address area which is vertical to the Attachments area.
Assignee | ||
Comment 5•24 years ago
|
||
Sorry, I didn't realize that there were two splitters...
Comment 6•24 years ago
|
||
No problem, I'm just glad that I could reproduce the problem :-)
Assignee | ||
Comment 9•22 years ago
|
||
Comment 10•22 years ago
|
||
taking all of varada's bugs.
Assignee: varada → sspitzer
Status: ASSIGNED → NEW
Assignee | ||
Updated•22 years ago
|
Attachment #89698 -
Flags: review?(cavin)
Comment 11•22 years ago
|
||
Comment on attachment 89698 [details] [diff] [review]
Proposed patch
r=cavin.
Attachment #89698 -
Flags: review?(cavin) → review+
Updated•20 years ago
|
Product: MailNews → Core
Comment 12•17 years ago
|
||
sorry for the spam. making bugzilla reflect reality as I'm not working on these bugs. filter on FOOBARCHEESE to remove these in bulk.
Assignee: sspitzer → nobody
Comment 13•17 years ago
|
||
resolved fixed?
Assignee | ||
Comment 14•17 years ago
|
||
We can alternatively fix this bug by moving the splitter inside the toolbar
(this has recently been made possible on trunk using resizeafter="grow").
Assignee | ||
Comment 15•17 years ago
|
||
Alternatively we could go for a revised version of my original patch; this patch also fixes an add/removeEventListener mismatch and hides the splitter when you collapse the addressing toolbar.
Attachment #284935 -
Flags: review?(mnyromyr)
Comment 16•17 years ago
|
||
would this help with anything in Bug 290865 comment 3?
Assignee | ||
Comment 17•17 years ago
|
||
(In reply to comment #16)
>would this help with anything in Bug 290865 comment 3?
No, it's not; this only applies to the use of the toolbargrippy.
Comment 18•17 years ago
|
||
Comment on attachment 284934 [details] [diff] [review]
Updated patch, version 1
Having the splitter right of the grippy looks just weird.
Attachment #284934 -
Flags: review?(mnyromyr) → review-
Comment 19•17 years ago
|
||
Comment on attachment 284935 [details] [diff] [review]
Updated patch, version 2
I prefer this approach, but is has issues: if you drag the splitter upwards, it will finally start to hide the subject row. If you drag on, it will even hide almost all of the address bar - but the listbox lines will shine through! And furthermore, if you let go of the splitter, it will jump back down to guarantee a minheight for the addressbar.
So, either the splitter should really hide _all_ stuff and remain where it was dragged to or it shouldn't be draggable that far...
Attachment #284935 -
Flags: review?(mnyromyr) → review-
Assignee | ||
Comment 20•17 years ago
|
||
The resizing issue appears to be due to the min-height in toolkit's toolbar.css
Attachment #284935 -
Attachment is obsolete: true
Attachment #289791 -
Flags: review?(mnyromyr)
Updated•17 years ago
|
Attachment #289791 -
Flags: review?(mnyromyr) → review+
Assignee | ||
Comment 21•17 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•