Closed Bug 61285 Opened 24 years ago Closed 24 years ago

Character Coding menu check mark is set wrong for messages with non MIME header

Categories

(MailNews Core :: Internationalization, defect, P3)

x86
Windows 2000
defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.8

People

(Reporter: ezh, Assigned: nhottanscp)

References

Details

(Keywords: intl)

Attachments

(2 files)

I did not tested it with mail. Only on news. This message was written in win-1251 codepage. But in the 3-pane window mozilla do not let me change from default KOI-8 (what is the most used russian codepage for mail/news) to win-1251 to view it. Opening the message in a separate window allows me to change and view it. Here's the header of the message: Path: localhost!not-for-mail From: "Michael Bakhtin" <michael@reget.com> Newsgroups: regetsoft.public.regetjr.support.ru Subject: ReGet Junior build 17 Date: Mon, 27 Nov 2000 04:01:50 +0300 Organization: ReGet Ltd. Lines: 16 Message-ID: <8vs8fo$a8h$1@master.melmac.net> NNTP-Posting-Host: ip-73.fixed.cl.spb.ru X-Trace: master.melmac.net 975283512 10513 212.46.195.73 (27 Nov 2000 00:05:12 GMT) X-Complaints-To: news@news.melmac.net NNTP-Posting-Date: 27 Nov 2000 00:05:12 GMT X-Priority: 3 X-MSMail-Priority: Normal X-Newsreader: Microsoft Outlook Express 5.50.4133.2400 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400 Xref: localhost regetsoft.public.regetjr.support.ru:45
I got it! The problem is that the point was set to win-1251 (in view -> character coding), but displayed it was in KOI-8 anyway. When I click on already pointed win-1251 all displays fine.
Summary: Can't change the character set in message → The point in used codepage is set wrong
>The problem is that the point was set to win-1251 (in view -> character coding), I don't understand this. What do you mean "the point"?
The "point" - the circle near codepage 's name that shows which one is in use right now. Do not know how to explain... Wanna screenshot by e-mail?
Okay I understand, I am not sure how to call it either (bullet, check mark?).
Status: NEW → ASSIGNED
Eugene, did you enable Russian auto detector when you tested? I cannot connect to the newsgroup.
No, cause with this setting there is no way to read all russian messages bug 58236
I need a reproducible case in order to debug.
I am not sure if this is really a bug. The first thing we need to do is to figure out: 1. What is the default Mail/news viewing charset value? Edit | Prefs | Mail & Newsgroup | Display | Languages | Character Coding KOI8-R or Windows-1251 2. The sample message has no MIME charset and so if the message encoding does not match the Mail display defualt in 1, what you're seeing would be a normal thing. Please provide additional data and if possible an entire message which exhibits this porblem in an attachment.
I think the following steps should work with two any encodings, but I used Win-1251 and KOI8-R 1. Set up default message encoding to KOI8-R 2. select any message without specified charset 3. select view\character coding\windows-1251 4. select another message without specified charset actual results: the message is displayed in KOI8-R, but the check mark is on win-1251
Max, thank you. Yes, this seems to be a bug -- we don't update the charset menu 'bullet' with the default view encoding selection when the message has no charset info. The problem shows up in 2 ways: 1. When you first display a message without any MIME charset info, no menu item is "bulltted". 2. When you correct the menu encoding item, and if the next message lacks MIME-charset info, then the next message simply shows the bullet next to the encoding of the prior message rather than the default encoding. I think we should fix this so that in both 1 and 2 above, we show the bullet mark for the default view encoding selection.
There is another question related to this bug. That is, do we update the Mail encoding cache correctly with current builds? I am not seeing that the cache is being updated correctly.
Keywords: intl, nsbeta1
QA contact to marina.
QA Contact: momoi → marina
Summary: The point in used codepage is set wrong → Character Coding menu check mark is set wrong for messages with non MIME header
Target Milestone: --- → mozilla0.8
The problem is that we have no check mark in the menu when the message does not have a charset label. This causes another problems like quoting does not work correctly. The patch is to set the folder charset in nsStreamConverter. This is an obvious place to set the folder charset but I am not sure if any better place to do that. Scott, could you review the patch?
looks good. sr=mscott
sr=bienvenu
The first patch has a problem that overwrites the manual override. I moved the code after we check the manual override. If no manual override then set the folder charset as a menu checkmark.
sr=bienvenu
*** Bug 67029 has been marked as a duplicate of this bug. ***
Naoki, it looks like you already got a super review from Bienvenu on this back on 1/31. I didn't bother giving it another super review 'cause you already had one. Sorry if you've been waiting all this time for me to look at it again. sr=mscott as well.
checked in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
verified with 2001-02-08 mtrunk build: folder charset appears as a menu checkmark
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: