The JavaScript focus() method should place the keyboard focus in the input edit field, as it does for <input type="text"> I haven't tested other JavaScript methods, but they probably should be investigated as well.

Eric, I'm re-assigning this to you since your working on this form element.

mass-moving all m12 bugs to m13

giving me rest of phillips open qa contact bugs, sorry for spam

pushing to m14

*IGNORE* - massive spam changing open XPToolkit bug's QA contact to jrgm@netscape.com

Rod this is an html control.

fixed.

I can't get filecontrol.focus() to work, but should it work? Allowing it would make exploits easier. If it's not supposed to work, it should fail completely instead activating the window or losing the focus if the window is already active, which is what it does now.

This got broken when they turned on the new GfxTextControl. Here is the fix: Index: nsFileControlFrame.cpp =================================================================== RCS file: /cvsroot/mozilla/layout/html/forms/src/nsFileControlFrame.cpp,v retrieving revision 3.96 diff -u -r3.96 nsFileControlFrame.cpp --- nsFileControlFrame.cpp 2000/09/13 23:52:43 3.96 +++ nsFileControlFrame.cpp 2000/10/11 18:50:18 @@ -214,8 +214,13 @@ void nsFileControlFrame::SetFocus(PRBool aOn, PRBool aRepaint) { + // Fix for Bug 6133 if (mTextFrame) { - mTextFrame->SetFocus(aOn, aRepaint); + nsCOMPtr<nsIContent> content; + mTextFrame->GetContent(getter_AddRefs(content)); + if (content) { + content->SetFocus(mPresContext); + } } }

Fix looks good r=kmcclusk@netscape.om

sr=waterson

It might be a good idea to hold this patch until bug 57770 is fixed. Being able to focus the field makes it slightly easier to exploit a more general security hole involving file upload controls. (Bug 56236 shows an exploit that *mostly* gets around the annoyance of not being able to focus the control.)

I'll wait and check it in when the dependency clears - thanks for the heads up

This works for me. Can we mark it resolved?

marking worksforme.