Closed
Bug 62307
Opened 24 years ago
Closed 16 years ago
js ref build should be easy to build JS_THREADSAFE with tree-built nspr
Categories
(Core :: JavaScript Engine, defect, P3)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mike+mozilla, Assigned: jimb)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Per suggestion from Beard:
Building the js ref threadsafe currently requires installing NSPR in a specific
location; it'd be nice if it could just pick up NSPR from the mozilla build.
i.e. ../../dist rather than ../../dist/SomeOS_DBG.OBJ
The attached patch looks for jslock.h in ../../dist/SomeOS_DBG.OBJ before
defaulting to ../../dist; it also moves some shared bits between Makefile.ref
and liveconnect/Makefile.ref to jsconfig.mk.
Reporter | ||
Comment 1•24 years ago
|
||
Reporter | ||
Comment 2•24 years ago
|
||
Not technically mozilla-tree, but I think it still deserves a look.
r=?
Comment 3•24 years ago
|
||
Would you regenerate this patch using cvs diff -u from the mozilla directory? I'm
having trouble applying it otherwise. I always have trouble applying multiple
directory patches.
Comment 4•24 years ago
|
||
Ahh, got the patch to work on the Mac, never mind.
Updated•24 years ago
|
Assignee: mike+mozilla → beard
Comment 5•24 years ago
|
||
Reassigning Mike's JS Engine bugs to Patrick, as per recent meeting -
Comment 7•24 years ago
|
||
I'm rather swamped at the moment, but will have a look Real Soon Now.
Comment 8•20 years ago
|
||
The following post appears to have a solution this issue, though perhaps not
as elegant as the attachment:
http://groups.google.ca/groups?hl=en&lr=&ie=UTF-
8&selm=7be32359.0403171719.2ef8666%40posting.google.com
Updated•19 years ago
|
Assignee: beard → general
QA Contact: pschwartau → general
Target Milestone: Future → ---
Comment 9•18 years ago
|
||
Depends on bug 97954? This could be a --with-nspr= option to configure if we had autoconf
Assignee: general → crowder
Depends on: 97954
Updated•18 years ago
|
Status: NEW → ASSIGNED
Comment 10•17 years ago
|
||
This should be part of the autoconf effort, if it hasn't been handled there already. jimb: can you own?
Assignee: crowder → jim
Status: ASSIGNED → NEW
Assignee | ||
Comment 11•17 years ago
|
||
Sure. The patches for 97954 already implement this: you pass --with-system-nspr (boolean), and --with-nspr-prefix=PATH. It tries to run PATH/bin/nspr-config.
Assignee | ||
Updated•17 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → DUPLICATE
Comment 13•17 years ago
|
||
It's not a duplicate, as abstractly either could be fixed without the other. Just depends-on is appropriate, and when the new SM build lands Jim can close two bugs (he certainly earned it). ;-)
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Comment 14•16 years ago
|
||
w00t
Status: REOPENED → RESOLVED
Closed: 17 years ago → 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•