Closed Bug 62307 Opened 24 years ago Closed 16 years ago

js ref build should be easy to build JS_THREADSAFE with tree-built nspr

Categories

(Core :: JavaScript Engine, defect, P3)

x86
Linux
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: mike+mozilla, Assigned: jimb)

References

Details

Attachments

(1 file)

Per suggestion from Beard: Building the js ref threadsafe currently requires installing NSPR in a specific location; it'd be nice if it could just pick up NSPR from the mozilla build. i.e. ../../dist rather than ../../dist/SomeOS_DBG.OBJ The attached patch looks for jslock.h in ../../dist/SomeOS_DBG.OBJ before defaulting to ../../dist; it also moves some shared bits between Makefile.ref and liveconnect/Makefile.ref to jsconfig.mk.
Not technically mozilla-tree, but I think it still deserves a look. r=?
Would you regenerate this patch using cvs diff -u from the mozilla directory? I'm having trouble applying it otherwise. I always have trouble applying multiple directory patches.
Ahh, got the patch to work on the Mac, never mind.
Assignee: mike+mozilla → beard
Reassigning Mike's JS Engine bugs to Patrick, as per recent meeting -
Marking future, hoping mang will review.
Target Milestone: --- → Future
I'm rather swamped at the moment, but will have a look Real Soon Now.
The following post appears to have a solution this issue, though perhaps not as elegant as the attachment: http://groups.google.ca/groups?hl=en&lr=&ie=UTF- 8&selm=7be32359.0403171719.2ef8666%40posting.google.com
Assignee: beard → general
QA Contact: pschwartau → general
Target Milestone: Future → ---
Depends on bug 97954? This could be a --with-nspr= option to configure if we had autoconf
Assignee: general → crowder
Depends on: 97954
Status: NEW → ASSIGNED
No longer depends on: 97954
Depends on: 97954
This should be part of the autoconf effort, if it hasn't been handled there already. jimb: can you own?
Assignee: crowder → jim
Status: ASSIGNED → NEW
Sure. The patches for 97954 already implement this: you pass --with-system-nspr (boolean), and --with-nspr-prefix=PATH. It tries to run PATH/bin/nspr-config.
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → DUPLICATE
It's not a duplicate, as abstractly either could be fixed without the other. Just depends-on is appropriate, and when the new SM build lands Jim can close two bugs (he certainly earned it). ;-)
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
w00t
Status: REOPENED → RESOLVED
Closed: 17 years ago16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: