Closed
Bug 624936
Opened 14 years ago
Closed 14 years ago
Cannot close tab group if it has certain size because "rename" field pops up and overlays close button
Categories
(Firefox Graveyard :: Panorama, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: florian.neubauer.neuroscience, Assigned: raymondlee)
References
Details
(Whiteboard: [ux][polish][good first bug])
Attachments
(2 files, 2 obsolete files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:2.0b8) Gecko/20100101 Firefox/4.0b8
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b8) Gecko/20100101 Firefox/4.0b8
When a tab group in panorama has a certain size, and you try to close it using the "x" close button, moving the mouse over the close button makes the "rename" field pop up and overlay the close button. Result: You cannot close the group.
Reproducible: Always
Steps to Reproduce:
1. Play with tab group size.
2. Try to close the group.
3. The "rename" field will prevent you from doing so.
Actual Results:
Rename field has focus and you cannot click the close button.
Expected Results:
Rename field would respect = not overlay the close button.
Reporter | ||
Comment 1•14 years ago
|
||
Comment 2•14 years ago
|
||
Opps.
Comment 3•14 years ago
|
||
Moving to beta 11. Would be great to get a patch for this.
Updated•14 years ago
|
Priority: P2 → P3
Assignee | ||
Comment 4•14 years ago
|
||
Assignee | ||
Comment 5•14 years ago
|
||
Tested the builds on Mac, Windows XP and Ubuntu, all work fine.
Comment 6•14 years ago
|
||
Comment on attachment 510522 [details] [diff] [review]
v1
This works. f+
+ Gavin for quick review while Ian is out.
Attachment #510522 -
Flags: review?(gavin.sharp)
Attachment #510522 -
Flags: feedback+
Comment 7•14 years ago
|
||
Is there no more efficient selector you can use (avoiding the descendant selector?). Where is this DOM constructed in the code?
Comment 8•14 years ago
|
||
(In reply to comment #7)
> Is there no more efficient selector you can use (avoiding the descendant
> selector?).
Right now we're also using .close for the tab close button. We could change them to be .tabClose and .groupClose, for example... do you think that's a worthwhile change?
> Where is this DOM constructed in the code?
http://hg.mozilla.org/mozilla-central/file/tip/browser/base/content/tabview/groupitems.js#l156
Comment 9•14 years ago
|
||
Comment on attachment 510522 [details] [diff] [review]
v1
Looks good to me. I look forward to Gavin's response.
Attachment #510522 -
Flags: review?(ian) → review+
Comment 10•14 years ago
|
||
Gavin, any additional comments on the new patch?
Comment 11•14 years ago
|
||
Comment on attachment 510522 [details] [diff] [review]
v1
Let's land this
Attachment #510522 -
Flags: review?(gavin.sharp)
Assignee | ||
Updated•14 years ago
|
Attachment #510522 -
Flags: approval2.0?
Comment 12•14 years ago
|
||
Comment on attachment 510522 [details] [diff] [review]
v1
a=beltzner, simple CSS fix
Attachment #510522 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Comment 13•14 years ago
|
||
Attachment #510522 -
Attachment is obsolete: true
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 16•14 years ago
|
||
This should be applied cleanly.
Attachment #513168 -
Attachment is obsolete: true
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Comment 17•14 years ago
|
||
Comment 18•14 years ago
|
||
Mozilla/5.0 (Windows NT 5.1; rv:2.0b12pre) Gecko/20110220 Firefox/4.0b12pre
Close button accessible when hovering with mouse. Issue verified with latest trunk.
Status: RESOLVED → VERIFIED
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•