The goal of this bug is to draw the title bar of the window on XP down to behind the tabs in the tabstrip, when tabs are on top. This helps to establish a difference between the browser level and the tab level, and makes it clearer that controls on the tab level will act on that particular tab. On Vista and 7 we are currently doing this with a single surface of glass continuing from the title bar down to behind the tabstrip. XP is more colorful and opaque, so the implementation here is sort of a persona that we apply for the default theme. Here are a few example mockups from Stephen: Luna Blue: https://wiki.mozilla.org/images/a/ac/Firefox-4-Mockup-i06-%28XP%29-%28LunaBlue%29-%28TabsTop%29-%28MenuBar%29.png Luna Silver: https://wiki.mozilla.org/images/2/27/Firefox-4-Mockup-i06-%28XP%29-%28Silver%29-%28TabsTop%29-%28MenuBar%29.png Luna Olive: https://wiki.mozilla.org/images/f/fe/Firefox-4-Mockup-i06-%28XP%29-%28LunaOlive%29-%28TabsTop%29-%28MenuBar%29.png Royale: https://wiki.mozilla.org/images/e/e8/Firefox-4-Mockup-i06-%28XP%29-%28Royale%29-%28TabsTop%29-%28MenuBar%29-%28BookmarksBar%29.png Zune: https://wiki.mozilla.org/images/7/74/Firefox-4-Mockup-i06-%28XP%29-%28Zune%29-%28TabsTop%29-%28MenuBar%29.png This is only the visual treatment for the default state of when tabs are on top. When tabs are on bottom, we fall back to a more classic appearance: https://wiki.mozilla.org/images/6/6e/Firefox-4-Mockup-i06-%28XP%29-%28LunaBlue%29-%28TabsBottom%29-%28MenuBar%29.png Quick note on why this bug is getting filed so late: This work has been waiting on the platform capability to detect the current OS theme (bug 543910), which has now been resolved. This work was also initially being held up by bug 590945, implementing the entire window frame in xul. However, we don't actually need to control the border on the left, right and bottom to successfully implement this change (however there might have to be some minor adjustments to gradients used so that they mesh with the native border better).

Requesting blocking since this represents a significant visual change to the XP theme, and the underlying platform work required to implement this change is now complete.

We have to ship! Why would we even consider this now?

My understanding is that the risk is roughly the same as applying a persona. But yeah, if this caused any immediate regressions we would obviously want to back it out and give up.

I really can't bring myself to block on this at this point and with the current pressure to get to a final release. If it turns out that someone can put together a patch, I'd look at approval, but to put any amount of focus on this at this point feels disingenuous. That said, when the Firefox Button is shown XP looks pretty assy without this. Ugh. Hard decision is hard.

Dao/Fryn/Gavin/Shorlander: if it's just CSS/applying a persona, though, let me know and I might reconsider. I'm having a hard time understanding the risk involved as I read through the recently resolved dependencies.

(In reply to comment #5) > Dao/Fryn/Gavin/Shorlander: if it's just CSS/applying a persona, though, let me > know and I might reconsider. I'm having a hard time understanding the risk > involved as I read through the recently resolved dependencies. I could be totally wrong but my understanding is that we are drawing this area now but just picking up the appearance from the system. So the change would involve custom CSS for the titlebar and adjusted CSS for the tab strip. That said I haven't looked into actually trying that at all. Jimm could probably clarify the actual risk.

(In reply to comment #6) > (In reply to comment #5) > > Dao/Fryn/Gavin/Shorlander: if it's just CSS/applying a persona, though, let me > > know and I might reconsider. I'm having a hard time understanding the risk > > involved as I read through the recently resolved dependencies. > > I could be totally wrong but my understanding is that we are drawing this area > now but just picking up the appearance from the system. So the change would > involve custom CSS for the titlebar and adjusted CSS for the tab strip. > > That said I haven't looked into actually trying that at all. Jimm could > probably clarify the actual risk. Dao can confirm, but yes I believe this is correct, it's just a swap out of styles and some new custom backgrounds. We currently render everything in the titlbar when the fx button is enabled, relying on the windows theme code for background painting. So for example the middle background section is handled by two -moz-appearance styles, -moz-window-titlebar and -moz-window-titlebar-maximized. These set minimum heights and paint the default windows titlebar graphics. You can remove those and apply your own styling.

We don't render the title bar when the menu bar is enabled.

Any hint of which release this will be targeted for?

Any news about this bug? Current Firefox do not match mockups for v4.0

Still planned, just waiting on work in bug 590945 to complete (it's in progress).

(In reply to comment #11) > Still planned, just waiting on work in bug 590945 to complete (it's in > progress). tnx for explanation

Any news about this bug? Current Firefox do not match mockups for v4.0. And v6 just shipped.

This is a dupe of bug 813802.