Closed Bug 631598 Opened 14 years ago Closed 14 years ago

Panorama uses the wrong font on Mac

Categories

(Firefox Graveyard :: Panorama, defect)

Product:
Firefox Graveyard
Component:
Panorama
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: pcwalton, Assigned: pcwalton)

References

Details

(Keywords: polish)

Attachments

(2 files, 4 obsolete files)

Proposed patch, version 5.
(deleted), patch
faaborg
: ui-review+
sdwilsh
: approval2.0+
Details | Diff | Splinter Review
Screenshot.
(deleted), image/png
Details
On the Mac, Panorama uses Tahoma instead of Lucida Grande, the UI font.
Keywords: polish
Attached patch Proposed patch. (obsolete) (deleted) — — Splinter Review
Proposed patch attached.
Attachment #509831 - Flags: review?(ian)
Depends on: 630777
I believe just font: message-box; should work here.
(In reply to comment #2) > I believe just font: message-box; should work here. It doesn't work, because Panorama changes the font size manually, which overrides that font declaration. We need to set only the font family.
This works just fine over here: data:text/html,<body style="font: message-box; font-size: 20px">Test
Attached patch Proposed patch, version 2. (obsolete) (deleted) — — Splinter Review
Oh, huh, if you leave the font-size in it works. Thanks for the tip. Here's a new patch that fixes Windows as well (bug 630777).
Attachment #509831 - Attachment is obsolete: true
Attachment #509875 - Flags: review?(ian)
Attachment #509831 - Flags: review?(ian)
What's the !importing supposed to override?
Attached patch Proposed patch, version 3. (obsolete) (deleted) — — Splinter Review
Dunno, but removing it seems to work. New patch attached.
Attachment #509875 - Attachment is obsolete: true
Attachment #509876 - Flags: review?(ian)
Attachment #509875 - Flags: review?(ian)
Comment on attachment 509876 [details] [diff] [review] Proposed patch, version 3. Please remove the !important in gnomestripe as well.
Attachment #509876 - Flags: review?(ian) → review+
Attached patch Proposed patch, version 4. (obsolete) (deleted) — — Splinter Review
Patch version 4 attached. Requesting approval; this is a very low-risk three-line CSS change that changes the font of the tabs.
Attachment #509876 - Attachment is obsolete: true
Attachment #509880 - Flags: approval2.0?
Comment on attachment 509880 [details] [diff] [review] Proposed patch, version 4. Why "font" on linux and mac but "font-family" on windows?
Blocks: 630777
No longer depends on: 630777
Attached patch Proposed patch, version 5. (deleted) — — Splinter Review
Ouch, leave it to me to screw that up. New version of the patch attached.
Attachment #509880 - Attachment is obsolete: true
Attachment #509889 - Flags: approval2.0?
Attachment #509880 - Flags: approval2.0?
Blocks: 627096
Comment on attachment 509889 [details] [diff] [review] Proposed patch, version 5. This should have ui-review before asking for approval.
Attachment #509889 - Flags: approval2.0?
Attachment #509889 - Flags: ui-review?(faaborg)
Attached image Screenshot. (deleted) —
Screenshot attached.
Attachment #509889 - Flags: ui-review?(faaborg) → ui-review+
Comment on attachment 509889 [details] [diff] [review] Proposed patch, version 5. Approval requested again!
Attachment #509889 - Flags: approval2.0?
Attachment #509889 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/791cca7bf97b
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b12pre) Gecko/20110215 Firefox/4.0b12pre Verified issue and it's no longer present.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: