Closed
Bug 632280
Opened 14 years ago
Closed 14 years ago
Remove NS_NOTREACHED occurrences near nsCacheEntryDescriptor.cpp:686
Categories
(Core :: Networking: Cache, defect)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla2.0b12
People
(Reporter: seanedunn, Assigned: seanedunn)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
khuey
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
This assert is causing a debug popup for Panorama when calling NetUtil.asyncCopy() and is blocking Panorama bug 604699.
File:
http://mxr.mozilla.org/mozilla-central/source/netwerk/cache/nsCacheEntryDescriptor.cpp#686
Background conversation:
[20:33] <khuey|away> the async copy code probes WriteSegments to see if the stream is buffered
[20:33] <khuey|away> so asserting that the method is never called is silly
[20:34] <khuey|away> asserting that xpcom interface methods are never called is silly in general
Component: General → Networking: Cache
Product: Firefox → Core
QA Contact: general → networking.cache
Assignee: nobody → seanedunn
Status: NEW → ASSIGNED
Attachment #510505 -
Flags: review?(bzbarsky)
Attachment #510505 -
Flags: feedback?(khuey)
|
||
Updated•14 years ago
|
Attachment #510505 -
Flags: review?(bzbarsky) → review+
Attachment #510505 -
Flags: feedback?(khuey)
Found additional asserts in nsStorageStream which are blocking the async implementation of bug 604699.
Attachment #510505 -
Attachment is obsolete: true
Attachment #510844 -
Flags: review?
Attachment #510844 -
Flags: review? → review+
|
||
Updated•14 years ago
|
Attachment #510844 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #510844 -
Flags: approval2.0? → approval2.0+
Pushed to try: http://tbpl.mozilla.org/?tree=MozillaTry&rev=d28fbe4e5447
Keywords: checkin-needed
|
||
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
You need to log in
before you can comment on or make changes to this bug.
Description
•