Closed Bug 63416 Opened 24 years ago Closed 21 years ago

allow INI components and sections to be listed out of order

Categories

(SeaMonkey :: Installer, defect)

All
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.8alpha1

People

(Reporter: ssu0262, Assigned: ajschult784)

Details

(Whiteboard: [xpiprd])

Attachments

(1 file)

The installer currently has a cumbersome way to adding new components to be recognized and therefore installed. When adding a new component, the user has to make sure that the section name for the component in the config.ini file is in a sequential numbering order, ie: ... Component10 Component11 Component12 ... And in addition to this requirement, each Setup TypeX section need to contain the components in a certain sequential order. [Setup Type0] C0=Component10 C1=Component11 C2=Component12 ... This makes it extremely *difficult* and *confusing* to verify a change from a given patch (as was encountered many times in the RTM release process). The simplification is to remove the 1st requirement so that arbitrary component section names can be used. This will make it easier to define and add new components to each of the [Setup TypeX] sections.
The equivalent is already done on Windows.
Keywords: nsbeta1
Whiteboard: [xpiprd]
Summary: need to simplify the addition of components → need to simplify the addition of components (Linux)
QA Contact: gemal → gbush
Moz 0.9 tasks
Target Milestone: --- → mozilla0.9
Priority: -- → P3
Priority: P3 → P4
Keywords: nsbeta1nsbeta1-
Target Milestone: mozilla0.9 → ---
Keywords: nsbeta1-
Over to Syd for installer bug triage
Assignee: sgehani → syd
Target Milestone: --- → M1
Target Milestone: M1 → Future
*** Bug 170170 has been marked as a duplicate of this bug. ***
==> me
Assignee: slogan → ajschult
Priority: P4 → --
Hardware: PC → All
Target Milestone: Future → mozilla1.8alpha
this patch removes the requirement for sequentially listed sections and keys as initially reported. the problem was that the parser was matching the first hit for "Component1", which could be "Component10" if the components were listed out of order. this will not fix bug 170170, which would require much more substantial changes.
Attachment #143175 - Flags: review?(bsmedberg)
Summary: need to simplify the addition of components (Linux) → allow INI components and sections to be listed out of order
Attachment #143175 - Flags: review?(bsmedberg) → review+
Attachment #143175 - Flags: superreview?(bryner)
Attachment #143175 - Flags: superreview?(bryner) → superreview+
marking FIXED. further overhaul of of INI parser will happen in bug 170170
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: