Bug 628179 is really messing me up - I'm used to being able to open the findbar while a page is loading, and then type something once the page has finished loading. This no longer works because the end of the page load now closes the find bar. I think this is a common findbar-power-user scenario. I propose we avoid auto-closing it if it has focus.

It actually hides on location change, before the load has finished.

This is what I tried. I'm not sure it helps much, since there are various ways that the findbar can be unfocused when I still intend to use it. I think I need to test this out more.

Comment on attachment 513245 [details] [diff] [review] patch >+ // Check to see whether the find bar text box is focused, in which case >+ // we avoid closing it. If the findbar input is focused, focusedElement >+ // will be its anonymous html:input, so check for that className first >+ // to avoid extra work in the case where something else is focused. >+ let focusedElement = document.commandDispatcher.focusedElement; >+ if (focusedElement && focusedElement.className.contains("textbox-input")) { >+ let bindingParent; >+ while ((bindingParent = document.getBindingParent(focusedElement))) >+ focusedElement = bindingParent; >+ if (focusedElement == gFindBar) >+ closeFindBar = false; >+ } >+ >+ if (closeFindBar) >+ gFindBar.close(); You can use gFindBar.getElement("findbar-textbox").hasAttribute("focused")

Looks like the part about "Findbar closes at the end of loading" has been resolved in some of the last nightly builds. Is the focus thing still an issue? The bar loses focus when navigating or switching the tab happens anyways. It would be fine to implement it, just in case and to gain some bonus points. ^^

This doesn't apply anymore, since bug 628179 has been backed out.