(ok, lousy bug description, but it was the best I could come up with) This is a small patch to make the close and add tab in Firefox to use glyphs instead of full color icons on Linux. They are svg's and uses the ButtonText color, so they will work on whatever crazy colors your OS widget theme does.

Forgot to remove a line I commented out.

I agree. The GTK close button is usually too thick for our UI. We need a more subtle design. Here are dozens of screenshots of the close button in the wild: http://imgur.com/a/3SUqp As we can see, most of them are way to thick. Andreas' approach looks good to me. Also, I would recommend to use this built-in icon everywhere we use the stock GTK icon, for consistency.

@Andreas, can you update your patch to use this icon everywhere the stock icon is used? Also, we need a 3 state button (normal, :hover, :hover:active).

This only includes the close button for now. In all places where the stock icon was previously used. This patch don't include the new tab icon as I wanted to keep the it simple.

(In reply to Paul Rouget [:paul] from comment #4) > Also, we need a 3 state button (normal, :hover, :hover:active). Do we? The current icon don't currently change color upon hover or hover active.

(In reply to Andreas Nilsson (:andreasn) from comment #6) > (In reply to Paul Rouget [:paul] from comment #4) > > Also, we need a 3 state button (normal, :hover, :hover:active). > Do we? The current icon don't currently change color upon hover or hover > active. They don't because we use a GTK icon. For Mac, http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/pinstripe/global/findBar.css#33 http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/pinstripe/global/icons/close.png And I think, at the same time, we can fix this workaround: http://mxr.mozilla.org/mozilla-central/search?string=XXX+Buttons&case=1&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Comment on attachment 579363 [details] [diff] [review] updated tab close icon patch (In reply to Andreas Nilsson (:andreasn) from comment #0) > They are svg's and uses the ButtonText > color, so they will work on whatever crazy colors your OS widget theme does. No, this won't work, as we use the icon on backgrounds other than ButtonFace. (In reply to Paul Rouget [:paul] from comment #3) > I agree. The GTK close button is usually too thick for our UI. We need a > more subtle design. What singles out our UI here? Seems like you should just file bugs / contact the authors for gtk themes with ugly close buttons.

(In reply to Dão Gottwald [:dao] from comment #8) > What singles out our UI here? Seems like you should just file bugs / contact > the authors for gtk themes with ugly close buttons. Most of the GTK close icons I saw so far don't really fit in our UI (too thick, or aggressive colors). I asked people on twitter to post the close button they use, here is the result: http://imgur.com/a/3SUqp (probably not representative of all our Linux users, but it shows the different kind of icons in the wild) I know that this will make Firefox a bit less-respectful of the native theme, but I really feel that the GTK close buttons never fit in our tabs. What are the downsides of using our own icon? (In reply to Dão Gottwald [:dao] from comment #8) > Comment on attachment 579363 [details] [diff] [review] [diff] [details] [review] > updated tab close icon patch > > (In reply to Andreas Nilsson (:andreasn) from comment #0) > > They are svg's and uses the ButtonText > > color, so they will work on whatever crazy colors your OS widget theme does. > > No, this won't work, as we use the icon on backgrounds other than ButtonFace. So what would the right value?

(In reply to Paul Rouget [:paul] from comment #9) > (In reply to Dão Gottwald [:dao] from comment #8) > > What singles out our UI here? Seems like you should just file bugs / contact > > the authors for gtk themes with ugly close buttons. > > Most of the GTK close icons I saw so far don't really fit in our UI (too > thick, or aggressive colors). I asked people on twitter to post the close > button they use, here is the result: http://imgur.com/a/3SUqp (probably not > representative of all our Linux users, but it shows the different kind of > icons in the wild) That doesn't answer my question. What makes those icons ugly for us but not for other gtk apps? My understanding is that they're just as ugly e.g. for gedit and should be fixed upstream. > I know that this will make Firefox a bit less-respectful of the native > theme, but I really feel that the GTK close buttons never fit in our tabs. > > What are the downsides of using our own icon? You just said it yourself: it makes Firefox integrate less with its environment. > > > They are svg's and uses the ButtonText > > > color, so they will work on whatever crazy colors your OS widget theme does. > > > > No, this won't work, as we use the icon on backgrounds other than ButtonFace. > > So what would the right value? There is no magic single value. It depends on the background. That's probably why the stock icons mix different colors and shades.

(In reply to Dão Gottwald [:dao] from comment #10) > My understanding is that they're just as ugly e.g. for gedit And that's true for Epiphany as well. > and should be fixed upstream. Fixing it upstream would mean contacting all the GTK theme authors. Do we know which are the most used GTK themes? Probably the default Ubuntu and Fedora themes. Using the GTK icon also gives us less control on the overall look of the tabs, which are a very important part of the UI. Well, this bring us to the native-theme vs custom-style question: to get a better looking UI on Linux, shouldn't we skip some GTK-specific rules? (not sure we should discuss this here). > > > > They are svg's and uses the ButtonText > > > > color, so they will work on whatever crazy colors your OS widget theme does. > > > > > > No, this won't work, as we use the icon on backgrounds other than ButtonFace. > > > > So what would the right value? > > There is no magic single value. It depends on the background. That's > probably why the stock icons mix different colors and shades. Interesting. Can we use the default text color?

(In reply to Paul Rouget [:paul] from comment #11) > Fixing it upstream would mean contacting all the GTK theme authors. Do we > know which are the most used GTK themes? Probably the default Ubuntu and > Fedora themes. Yeah, I think it would make sense to contact Ubuntu and Fedora people. If we can get a few popular themes improved, hopefully others will follow in order to remain competitive. Or maybe not, but then we don't need to bother because most people use the default theme anyway. > > There is no magic single value. It depends on the background. That's > > probably why the stock icons mix different colors and shades. > > Interesting. Can we use the default text color? There's no context-insensitive default text color... ButtonText pairs with ButtonFace, -moz-dialogText pairs with -moz-dialog, etc.

(In reply to Dão Gottwald [:dao] from comment #12) > (In reply to Paul Rouget [:paul] from comment #11) > > Fixing it upstream would mean contacting all the GTK theme authors. Do we > > know which are the most used GTK themes? Probably the default Ubuntu and > > Fedora themes. > > Yeah, I think it would make sense to contact Ubuntu and Fedora people. If we > can get a few popular themes improved, hopefully others will follow in order > to remain competitive. Or maybe not, but then we don't need to bother > because most people use the default theme anyway. I think most people use the default Fedora and Ubuntu themes, especially since GNOME made the theme selector less prominent with 3.0 (as in removed it, Ubuntu patched a combobox back in). Another possibility is that if we get Bug 627699 fixed, we might be able to use request the symbolic variant from the theme http://www.hadess.net/2010/04/symbolic-icons-support-in-gtk.html (I'm going to open bugs against Epiphany and gedit to use this as well :) > > > There is no magic single value. It depends on the background. That's > > > probably why the stock icons mix different colors and shades. > > > > Interesting. Can we use the default text color? > > There's no context-insensitive default text color... ButtonText pairs with > ButtonFace, -moz-dialogText pairs with -moz-dialog, etc. I could rework my patch to do it only for the tabs.

(In reply to Andreas Nilsson (:andreasn) from comment #13) > Another possibility is that if we get Bug 627699 fixed, we might be able to > use request the symbolic variant from the theme > http://www.hadess.net/2010/04/symbolic-icons-support-in-gtk.html (I'm going > to open bugs against Epiphany and gedit to use this as well :) Even if it's fixed in GTK3, we need something for GTK2. Andreas, feel like opening a bug upstream (Ubuntu and Fedora)?

Is this anywhere related to the linux users that see no button on windows like the inspector?

(In reply to Pedro Alves from comment #15) > Is this anywhere related to the linux users that see no button on windows > like the inspector? No.