Closed
Bug 635728
Opened 14 years ago
Closed 14 years ago
Favicon background must match group item background color
Categories
(Firefox Graveyard :: Panorama, defect, P4)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mitcho, Assigned: mitcho)
References
Details
(Whiteboard: [visual][polish])
Attachments
(2 files, 1 obsolete file)
|
(deleted),
image/png
|
faaborg
:
ui-review+
|
Details |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Before/after
In bug 618854, we changed the groupItem background color for Mac without updating the .favicon color to match.
|
Assignee | |
Comment 1•14 years ago
|
||
Alex, you can ui-review based on the previously attached before/after shot of this patch.
Assignee: nobody → mitcho
Status: NEW → ASSIGNED
Attachment #514024 -
Flags: ui-review?(faaborg)
Attachment #514024 -
Flags: review?(ian)
|
|
Assignee | |
Updated•14 years ago
|
Priority: -- → P4
|
||
Comment 2•14 years ago
|
||
Comment on attachment 514024 [details] [diff] [review]
Trivial patch
Thanks for catching this.
Faaborg is on vacation, and it's a trivial change ui-wise as well... consider this a ui-review+ from me. :)
Attachment #514024 -
Flags: ui-review?(faaborg)
Attachment #514024 -
Flags: review?(ian)
Attachment #514024 -
Flags: review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Comment on attachment 514024 [details] [diff] [review]
Trivial patch
Note to approvers: trivial CSS change for consistency (see before/after screenshot provided), r+ui-review from Ian.
Attachment #514024 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #514020 -
Flags: ui-review+
|
||
Comment 4•14 years ago
|
||
Comment on attachment 514024 [details] [diff] [review]
Trivial patch
a=beltzner
Attachment #514024 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 5•14 years ago
|
||
Attachment #514024 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 6•14 years ago
|
||
|
||
Comment 7•14 years ago
|
||
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0) Gecko/20100101 Firefox/4.0
Verified issue.
Status: RESOLVED → VERIFIED
|
||
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•