Closed
Bug 64007
Opened 24 years ago
Closed 24 years ago
Mozilla/Netscape hardcoded
Categories
(SeaMonkey :: Installer, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: BenB, Assigned: ssu0262)
References
Details
Attachments
(5 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
Reproduce:
1. Change the product name in makeall.pl
2. Install
3. Try to uninstall
Actual result:
Error. "3: Uninstall Log Folder not found"
Expected result:
Exactly the version which I start the uninstaller for is uninstalled.
Additional Comments:
This is because the reg keys for Mozilla and Netscape are hardcoded in the
(Un)Installer. See
<http://lxr.mozilla.org/seamonkey/source/xpinstall/wizard/windows/setup/extra.c#5385>
and
<http://lxr.mozilla.org/seamonkey/source/xpinstall/wizard/windows/uninstall/extra.c#1521>.
These "variables" are then referenced in uninstall.it etc..
I hope, it's clear that "Mozilla" *must not* be hardcoded. What do we have the
env. variables $ENV{WIZ_nameProduct} for?
Note that the code looks like that (apart from the hardcoded Mozilla) the *last
installed* version (as determined by SOFTWARE\Mozilla\Mozilla SeaMonkey\
CurrenntVersion" in the winreg) will be uninstalled, not the one passed via the
/ua param. Practically however, it seems to work ("uninstaller.exe /ua foobar"
uninstalls version foobar, no matter what CurrentVersion says).
Simon, please fix this.
Reporter | ||
Updated•24 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Reporter | ||
Comment 2•24 years ago
|
||
Another consequence: The installer will suggest to overwrite an existing Mozilla
installation.
I have a fix at hand that needs a little more testing and a sr=. It will remove
the hard coded strings.
Reassigning this to myself.
Assignee: slucy → ssu
Comment 4•24 years ago
|
||
Any idea of the kind of timescale? This is a show stopper on a package
release. I'm willing to test.
Reporter | ||
Comment 5•24 years ago
|
||
ssu, that's cool! Please attach the patch ASAP (i.e. today, if possible).
I'm going to try for today. I'm trying to do my normal testing procedures on my
patches, but there network is not cooperating today.
Simon, I might just send you the patch for you to test. It has about 3 other
fixes in addition to this one (it was hard to find people to sr= last week).
The fix to this bug requires a few minor changes to the config.ini and
uninstall.ini files.
Status: NEW → ASSIGNED
Reporter | ||
Comment 7•24 years ago
|
||
> I'm trying to do my normal testing procedures on my
> patches, but there network is not cooperating today.
Don't let that hold you back. There are several ways to fix this bug, some of
them might not help us, so I'd like to know which one you chose.
> Simon, I might just send you the patch for you to test.
Please cc me <ben.bucksch@beonex.com>.
> The fix to this bug requires a few minor changes to the config.ini and
> uninstall.ini files.
Expected :).
Assignee | ||
Comment 10•24 years ago
|
||
Assignee | ||
Comment 11•24 years ago
|
||
Assignee | ||
Comment 12•24 years ago
|
||
for mozilla only, apply the first 2 patches. The other two are nscp specific.
These patches also contain fixes for bugs # 64105, 60149, and 60039.
Reporter | ||
Comment 13•24 years ago
|
||
ssu,
fix approach looks good.
I am still vary of the uninstallation. Opened bug 64109 for that.
Simon,
I'll attach a patch without the unrelated changes. Can you then please try that out?
Assignee | ||
Comment 14•24 years ago
|
||
Reporter | ||
Comment 15•24 years ago
|
||
> (besides bug 64109 :) I'm already thinking about how to resolve that bug)
That's very nice, but it's not a short-term requirement.
Comment 16•24 years ago
|
||
See bug 64105 for final patches, r=dveditz@netscape.com
Assignee | ||
Comment 17•24 years ago
|
||
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 18•24 years ago
|
||
Reporter | ||
Comment 19•24 years ago
|
||
Fix seems to work (Uninstaller now fails for other reasons, probably rooted at our end).Thanks for the fast fix, ssu!
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•