Closed
Bug 644333
Opened 14 years ago
Closed 12 years ago
batch updating of counts to speed up operations on large numbers of messages
Categories
(Thunderbird :: Folder and Message Lists, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 538378
People
(Reporter: Bienvenu, Assigned: Bienvenu)
References
(Blocks 1 open bug)
Details
(Keywords: perf, Whiteboard: [bulkoperations])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
There are still places where we update counts in the folder pane in a tight loop. I've got a patch for one of these (involving saved searches, iirc).
Assignee | ||
Comment 1•14 years ago
|
||
this adds begin/end batching events to dbchangelisteners, and makes deleting imap messages use the batching events so the account manager knows to update counts once instead of on every deleted message in the loop.
Attachment #521498 -
Flags: superreview?(neil)
Attachment #521498 -
Flags: review?(bugzilla)
Comment 2•14 years ago
|
||
Comment on attachment 521498 [details] [diff] [review]
fix updating of virtual folder counts
Who sets m_updatePending?
Assignee | ||
Comment 3•14 years ago
|
||
(In reply to comment #2)
> Comment on attachment 521498 [details] [diff] [review]
> fix updating of virtual folder counts
>
> Who sets m_updatePending?
good question - this is a diff that's been hanging out in my tree for quite a while - I'll try to reconstruct it...
Assignee | ||
Comment 4•14 years ago
|
||
Comment on attachment 521498 [details] [diff] [review]
fix updating of virtual folder counts
the change in the vffolderchanger listener to use events posted to the ui thread to effectively implement batching makes the account manager changes moot. I'll see what's left that might be useful.
Attachment #521498 -
Flags: superreview?(neil)
Attachment #521498 -
Flags: superreview?
Attachment #521498 -
Flags: review?(bugzilla)
Attachment #521498 -
Flags: review?
Comment 5•14 years ago
|
||
xref Bug 636306 - Improve virtual folder / saved search performance - doesn't scale for large numbers of virtual folder
Assignee | ||
Updated•14 years ago
|
Attachment #521498 -
Flags: superreview?
Attachment #521498 -
Flags: review?
Assignee | ||
Comment 6•14 years ago
|
||
Attachment #521498 -
Attachment is obsolete: true
Attachment #521623 -
Flags: review?(neil)
Comment 7•14 years ago
|
||
Comment on attachment 521623 [details] [diff] [review]
use existing batching mechanism
I don't really understand the third parameter to EnableNotifications...
Attachment #521623 -
Flags: review?(neil) → review+
Updated•13 years ago
|
Status: NEW → ASSIGNED
Comment 8•13 years ago
|
||
neil, bienvenu, patch has r+ but I'm lost as to the potential for getting this checked in
what level of impact does this have for reducing memory usage?
Severity: normal → major
Whiteboard: [bulkoperations]
Assignee | ||
Comment 9•13 years ago
|
||
no memory usage improvements. I don't remember if I landed this, but if not, I suspect the same fix is also in the patch for bug 538378.
Comment 10•12 years ago
|
||
(In reply to David :Bienvenu from comment #9)
> no memory usage improvements. I don't remember if I landed this, but if not,
> I suspect the same fix is also in the patch for bug 538378.
not landed afaik, so trusting bienvenu
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•