Closed
Bug 64723
Opened 24 years ago
Closed 24 years ago
Make the Bookmark Manager use the shared Drag And Drop library
Categories
(SeaMonkey :: Bookmarks & History, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: bugs, Assigned: bugs)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
patch coming soon
|
Assignee | |
Comment 1•24 years ago
|
||
|
|
Assignee | |
Comment 2•24 years ago
|
||
|
||
Comment 3•24 years ago
|
||
need review?
|
||
Comment 4•24 years ago
|
||
| getValueFromResource: function(aResource)
| {
| aResource = aResource.QueryInterface(Components.interfaces.nsIRDFResource);
| return aResource ? aResource.Value : null;
| },
if aResource is null, this will fail (arguably okay), but how could aResource be
null after the QI? Or do you specifically want null instead of e.g. ""?
| getSupportedFlavours: function ()
| {
| var flavourSet = new FlavourSet();
| flavourSet.appendFlavour("moz/rdfitem");
| flavourSet.appendFlavour("text/x-moz-url");
| flavourSet.appendFlavour("text/unicode");
| return flavourSet;
| },
Would it be worth caching this object?
| if (!dropItem) {
| dropAction = "on";
| dropItem = containerItem.parentNode.parentNode;
| }
| }
A stray tab :-)
| var containerID = containerRef || containerItem.id;
|
| var rContainer = this.getResource(containerID);
You could merge those two for code similarity...
Just those nits, looks okay otherwise.
|
||
Comment 5•24 years ago
|
||
fix checked in. (ben, not hyatt)
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•