Closed Bug 653233 Opened 14 years ago Closed 14 years ago

Graphs no longer work on trunk

Categories

(Webtools Graveyard :: Graph Server, defect)

Product:
Webtools Graveyard
Component:
Graph Server
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: bzbarsky, Assigned: rhelmer)

References

Details

Attachments

(1 file, 1 obsolete file)

use getComputedStyle instead of document.width v2
(deleted), patch
catlee
: review+
Details | Diff | Splinter Review
Apparently they rely on the non-standard document.width/document.height and we removed those. See bug 585877.
Severity: normal → major
(In reply to comment #0) > Apparently they rely on the non-standard document.width/document.height and we > removed those. See bug 585877. I see what you mean on graphs.mozilla.org There is a new version (2.0) in the works on http://graphs.allizom.org (uses a nightly snapshot of production data), does everything look ok there? Does to me right now on latest Nightly. I think it's worth fixing for 1.0 though.
Assignee: nobody → rhelmer
Status: NEW → ASSIGNED
2.0 works, I'm told.
Attached patch use getComputedStyle instead of document.width (obsolete) (deleted) — — Splinter Review
Replaced document.width with document.defaultView.getComputedStyle(document.body,null).getPropertyValue('width')
Attachment #528730 - Flags: review?(catlee)
Attachment #528730 - Flags: feedback?(bzbarsky)
Comment on attachment 528730 [details] [diff] [review] use getComputedStyle instead of document.width This is fine, but you can just do |.width| instead of |.getPropertyValue("width")|.
Attachment #528730 - Flags: feedback?(bzbarsky) → feedback+
Also "getComputedStyle" instead of "document.defaultView.getComputedStyle"
More succinct version of attachment 528730 [details] [diff] [review]. Tested on both Firefox 4 and latest Nightly. Thanks bz/sicking for additional review. catlee, would you mind pushing this? I still don't seem to be able to push to hg.m.o/graphs, despite bug 635119.
Attachment #528730 - Attachment is obsolete: true
Attachment #528730 - Flags: review?(catlee)
Attachment #528802 - Flags: review?(catlee)
Comment on attachment 528802 [details] [diff] [review] use getComputedStyle instead of document.width v2 Problem with my hg account resolved, push changeset f7f5ddf4ee84
Attachment #528802 - Flags: review?(catlee)
Stage updated: http://graphs-stage.mozilla.org/graph.html Filed serverops bug 653358 to push to prod.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment on attachment 528802 [details] [diff] [review] use getComputedStyle instead of document.width v2 Looks like you pushed it already: http://hg.mozilla.org/graphs/rev/f7f5ddf4ee84
Attachment #528802 - Flags: review+
Depends on: 653358
Pushed to prod, WFM - http://graphs.mozilla.org
Status: RESOLVED → VERIFIED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: