Closed Bug 654594 Opened 14 years ago Closed 13 years ago

Remove WinCE & Windows Mobile code from security/coreconf/

Categories

(NSS :: Libraries, defect, P3)

All
Windows CE
defect

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 654611

People

(Reporter: emorley, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

WinCE & Windows Mobile code is being slowly removed by bug 614720 - since it's broken, no longer supported, and only serves to complicate code maintenance. This bug is for the security/coreconf/* parts of the removal: http://mxr.mozilla.org/mozilla-central/search?string=wince&find=/security/coreconf/
Attached patch Remove WinCE code from security/coreconf/* (obsolete) (deleted) — Splinter Review
Remove WinCE ifdefs from security/coreconf/ and also hg rm: security/coreconf/WINCE.mk
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Comment on attachment 529868 [details] [diff] [review] Remove WinCE code from security/coreconf/* Passed try: http://dev.philringnalda.com/tbpl/?tree=Try&rev=357126c2abd1
Attachment #529868 - Flags: review?(kaie)
directory security/coreconf belongs to NSS, changing component
Assignee: bmo → nobody
Component: Security → Libraries
Product: Core → NSS
QA Contact: toolkit → libraries
Version: Trunk → trunk
Comment on attachment 529868 [details] [diff] [review] Remove WinCE code from security/coreconf/* r=kaie
Attachment #529868 - Flags: review?(kaie) → review+
Only change is updated commit message to include r=kaie Carrying forwards r+ - Kai - thanks for the review / moving to the correct component :-)
Assignee: nobody → bmo
Attachment #529868 - Attachment is obsolete: true
Attachment #530116 - Flags: review+
Keywords: checkin-needed
This is a Hg patch, a patch to Firefox's downstream copy of NSS. Has a maintainer of that copy been identified?
The patch is intended for NSS CVS upstream, sorry for any confusion. It's only hg since http://www.mozilla.org/projects/security/pki/nss/ appeared out of date - so I thought the mention of CVS was an oversight (like on many of the MDN pages); so (incorrectly) presumed that development had moved to the mercurial m-c repo along with everything else. The NSS entry here https://developer.mozilla.org/en/Mozilla_Source_Code_Directory_Structure also also didn't mention development having to occur on another repo. If upstream wishes to wontfix, then it's not worth taking for m-c only.
(In reply to comment #6) > This is a Hg patch, a patch to Firefox's downstream copy of NSS. > Has a maintainer of that copy been identified? Nelson, no reason to worry. Patches can be created using hg, and still applied to a cvs tree. The copy in mozilla-central is a... copy. No need for a maintainer.
(In reply to comment #7) > > If upstream wishes to wontfix, then it's not worth taking for m-c only. I guess we want to take it, if wince is dead. I will raise the question during the NSS conference call, prior to checking in.
(In reply to comment #9) > I will raise the question during the NSS conference call, prior to checking in. Thanks Kai :-)
The following has been discussed in today's NSS conference call: - in theory, there might be additional users of this code - we don't want to remove it if there is still someone using it - in order to find out, a message will be sent to the dev-crypto newsgroup - if someone actively uses it, we'll keep it - if not, we'll remove it at some later time. Which means, despite having a r+ patch, please don't check in yet.
Keywords: checkin-needed
> - in theory, there might be additional users of this code > - we don't want to remove it if there is still someone using it > - in order to find out, a message will be sent to the dev-crypto newsgroup For reference: https://groups.google.com/d/topic/mozilla.dev.tech.crypto/Fb7BrL5m9y0/discussion
Flags: in-testsuite-
Severity: normal → trivial
Priority: -- → P3
Contents of patch moved to the main NSS bug 654611 to keep everything together.
Assignee: bmo → nobody
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: