Closed
Bug 65470
Opened 24 years ago
Closed 24 years ago
bookmarks window updates
Categories
(SeaMonkey :: Bookmarks & History, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: bugs, Assigned: bugs)
Details
Attachments
(46 files)
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
text/plain
|
Details | |
(deleted),
image/gif
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review |
"bugzilla as a cheap alternative to traditional backup methods"
Assignee | ||
Comment 1•24 years ago
|
||
Commence File Attachment, Part I (first cut)
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•24 years ago
|
||
Assignee | ||
Comment 3•24 years ago
|
||
Assignee | ||
Comment 4•24 years ago
|
||
Assignee | ||
Comment 5•24 years ago
|
||
Assignee | ||
Comment 6•24 years ago
|
||
Assignee | ||
Comment 7•24 years ago
|
||
Assignee | ||
Comment 8•24 years ago
|
||
Assignee | ||
Comment 9•24 years ago
|
||
Assignee | ||
Comment 10•24 years ago
|
||
Assignee | ||
Comment 11•24 years ago
|
||
Assignee | ||
Comment 12•24 years ago
|
||
OK, so this is a *preliminary cut*. I've included all of the files /diffs where
files aren't appropriate, but no build magic, I'll leave that to the reader to
set up for him/herself.
Not all the functionality works yet. This is a work in progress. Almost all
context menu functionality should work however as the new command system is
working. Menuitems/accelerators won't until I set the bookmarksController up to
pass through to my command system.
Comment 13•24 years ago
|
||
I installed the diffs/new files on build 2001011420 win32. Here are my first
impressions. Note that it's possible that I forgot a couple of things while
patching, so it might not be extremely accurate.
1) When launching Mozilla, I get "JS error : BookmarksTree is not defined,
line57 of bookmarks.js" in the console. line 56-57 :
"BookmarksWindow.prototype = {
__proto__: BookmarksTree.prototype,"
I'm not sure why bookmarks.js has to be loaded at startup, though.
2) Opening the Bookmarks Manager, I get no error (great!).
Inline editing rocks and works perfectly.
3) Drag and drop doesn't work. I get no error either, so I am guessing I did
something wrong when patching, or it's not hooked up yet.
4) Context menus's menuitems all show "null" as value, but of course there was
no diff/new file for bookmarks.properties, so it's kind of normal.
5) Menu items doesn't work, but you mentioned that above.
Hope this helps, this new bookmark manager looks extremely great!
Fabian.
Assignee | ||
Comment 14•24 years ago
|
||
"1) When launching Mozilla, I get "JS error : BookmarksTree is not defined,
line57 of bookmarks.js" in the console. line 56-57 :"
Yes, I have not yet patched navigator or restructured the personal toolbar. In
the old management system, all bm code was stored in bookmarks.js and this had
to be loaded by navigator. Now shared code is located in bookmarksOverlay.js,
which Navigator will be modified to load in an upcoming patch. The error is
harmless so I haven't yet fixed it.
"3) Drag and drop doesn't work. I get no error either, so I am guessing I did
something wrong when patching, or it's not hooked up yet."
The bookmarks window uses my updated drag and drop libraries, which aren't in
the tree yet. See bugs 64722 and 64723, which have patches attached. Most
importantly, you need nsDragAndDrop.js and nsTransferable.js.
"4) Context menus's menuitems all show "null" as value, but of course there was
no diff/new file for bookmarks.properties, so it's kind of normal."
Oops, I'll attach that with the next set of patches. I also have a modified
bookmarks.dtd
"5) Menu items doesn't work, but you mentioned that above."
I now have these mostly working with the command updater so things get
disabled/enabled.
More patches coming soon.
Assignee | ||
Comment 15•24 years ago
|
||
Second code drop. Comments after attachments
Assignee | ||
Comment 16•24 years ago
|
||
Assignee | ||
Comment 17•24 years ago
|
||
Assignee | ||
Comment 18•24 years ago
|
||
Assignee | ||
Comment 19•24 years ago
|
||
Assignee | ||
Comment 20•24 years ago
|
||
Assignee | ||
Comment 21•24 years ago
|
||
Assignee | ||
Comment 22•24 years ago
|
||
Assignee | ||
Comment 23•24 years ago
|
||
Assignee | ||
Comment 24•24 years ago
|
||
Assignee | ||
Comment 25•24 years ago
|
||
Assignee | ||
Comment 26•24 years ago
|
||
Assignee | ||
Comment 27•24 years ago
|
||
Assignee | ||
Comment 28•24 years ago
|
||
Assignee | ||
Comment 29•24 years ago
|
||
Assignee | ||
Comment 30•24 years ago
|
||
OK I think this is everything.
this time around, we have a toolbar, with a combo button for new items, the
three buttons to the left (properties, rename, delete) used to work but they
regressed recently on me. <Del> is buggy, doesn't always work. Tip: if you
accidentally delete too much (which can happen!) go to your debug console window
and hit Ctrl+C, or force quit the app. This way, changes aren't flushed to disk
and you can restart to restore your bookmarks.
Also implemented is a quickfile button. you can select items in the list and use
the file button's dropdown menu (a new widget) to file in a different folder, or
drag the selection onto the button and down into the menu (!). This action is
also somewhat spotty, but it works about 90% of the time.
Inline create new folder now works, sometimes it doesn't create a new inline
edit row. Inline create new bookmark is coded but doesn't work yet. You need to
apply the C++ part of the patch attached to 27495 to get this to work properly.
That's it for now, more later.
Comment 31•24 years ago
|
||
Adding self to CC so I can get a lot of spam while i'm skiing next week.
First impressions : New toolbar looks impressive, excellent work. All the
properties/dtd files are ok, I get menu item values now. Comments/Bugs :
1) The properties and rename shortcut don't work. No error in console.
2) Chosing the "copy" menu item in the edit menu crashed Mozilla.
3) I get a few "srGetStrBundle not defined" errors. Your probably forgot some
parenthesis or something like that.
4) I still get the BookmarksTree error, line 157 of bookmarks.js
5) The New Bookmark shortcut in the toolbar really creates a new Folder. If I
edit it inline, then type enter, the folder disappears. Also after it
disappears, when clicking anywhere, it edits the previous bookmark inline.
6) New separator doesn't work.
7) Sorting by clicking on the columns doesn't work. I get a "debug is not
defined" output in the console.
8) The "File Bookmark" feature rocks and works perfectly! Now if only you could
hook it up in the Bookmarks menu of the Personnal Toolbar and in the Bookmarks
Toolbar of the main menubar!
Disclaimer : I installed Jag's patch for the XBL-ified browser before using
these patches, so I may have totally screwed it, if the bugs I reported work
fine on your machine (which I doubt since you also tried Jag's patch), please
ignore them ;)
Keep up the excellent work!
Fabian.
Comment 32•24 years ago
|
||
Oh and a last trivial thing.. in the patch for stringbundleBindings.xml, line52-61 :
"var applicationLocale = null" . There is a missing semicolon.
Assignee | ||
Comment 34•24 years ago
|
||
Comment 35•24 years ago
|
||
r=blake on last patch
check this baby in.
Assignee | ||
Comment 36•24 years ago
|
||
Assignee | ||
Comment 37•24 years ago
|
||
Assignee | ||
Comment 38•24 years ago
|
||
Assignee | ||
Comment 39•24 years ago
|
||
Assignee | ||
Comment 40•24 years ago
|
||
Assignee | ||
Comment 41•24 years ago
|
||
Assignee | ||
Comment 42•24 years ago
|
||
Assignee | ||
Comment 43•24 years ago
|
||
Assignee | ||
Comment 44•24 years ago
|
||
Assignee | ||
Comment 45•24 years ago
|
||
Assignee | ||
Comment 46•24 years ago
|
||
Assignee | ||
Comment 47•24 years ago
|
||
Assignee | ||
Comment 48•24 years ago
|
||
Assignee | ||
Comment 49•24 years ago
|
||
Assignee | ||
Comment 50•24 years ago
|
||
Assignee | ||
Comment 51•24 years ago
|
||
Assignee | ||
Comment 52•24 years ago
|
||
Assignee | ||
Comment 53•24 years ago
|
||
Assignee | ||
Comment 54•24 years ago
|
||
Assignee | ||
Comment 55•24 years ago
|
||
Assignee | ||
Comment 56•24 years ago
|
||
Comment 57•24 years ago
|
||
Fixed. (ben, not hyatt)
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•