Closed Bug 65685 Opened 24 years ago Closed 24 years ago

move common used latin converter to uconv.dll to save footprint

Categories

(Core :: Internationalization, defect, P1)

x86
All
defect

Tracking

()

RESOLVED FIXED
mozilla0.8

People

(Reporter: ftang, Assigned: tetsuroy)

Details

Attachments

(7 files)

We should move "UTF-8" , "ISO-8859-1", "windows-1252" and "x-mac-roman" converters from ucvlatin to uconv so ucvlatin.dll won't load into memory for the top 100 English URLs. This way we can save some footprint (~100K ) in windows. Currently, ucvlatin is 180K in windows and if we can make sure ucvlatin is not loaded into memory for the top 100 URL then we can save those space.
We probably can save up to 50K of footprint for English user on top 100 URL by doing this work . Mark it as P1 and moz 0.8
Target Milestone: --- → mozilla0.8
mark it as P1
Priority: -- → P1
Status: NEW → ASSIGNED
Attached patch Adding them to uconv.dll (deleted) — Splinter Review
nhotta< I removed files from uconv/ucnlatin and added some to uconv/src. Can you update the Mac makefile for me? Thanks
Verified ucvLatin.dll won't get loaded after executing chofmann's top 100 site list. :0 Saving of 180KB in the debug build.
Once this bug is checked in, we can remove ucvlatin.dll from embedding makefile.
ftang: can you review the code for me? Thanks
bstell< can you verify the patch on Unix? 1) please make sure patch compiles the build 2) launch mozilla and view few URLs to see if it renders correctly for latin1. Thanks
ftang< can we review the patch again? Thanks
sr=ftang on the new patch. Make sure you test it on linux and Mac before you check in.
bstell< can you review my patches for Linux? nhotta< can you review my patches for Mac?
Jud: can you /r= my patch? I have bstell tested the build on Linux and nhotta tested on Mac.
I install the patch on linux and it builds and runs okay.
why do you need to manipulate the registry directly like this? doesn't NSGETMODULE do what you need?
Unfinished module include uconv.dll (see http://bugzilla.mozilla.org/show_bug.cgi?id=22921) I am going to covert uconv.dll to use NS_GETMODULE().
ftang: In 22921 <2000-01-10 14:25> comment, you decided to hold off the conversion. What was Cata's issue?
Jud: I am going to reopen (http://bugzilla.mozilla.org/show_bug.cgi?id=22921) to covert uconv.dll to use NS_GETMODULE(). Do you see any problem check-in these patches?
sounds good to me. r=valeski on the 2/5/01 16:02 patch.
You might want escaped-unicode and MUTF7 as well.
checked-in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Attached patch removing the Mac warning msg (deleted) — Splinter Review
QA Contact: teruko → ylong
Changed QA contact to ylong@netscape.com.
Looks like someone didn't get around to actually removing these files from intl/uconv/ucvlatin/. I filed bug 72308 on duplicate files (I didn't know about this bug until after I filed).
ftang: Please verify. QA can't verify this fix. :)
QA Contact: ylong → ftang
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: