Closed
Bug 65685
Opened 24 years ago
Closed 24 years ago
move common used latin converter to uconv.dll to save footprint
Categories
(Core :: Internationalization, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla0.8
People
(Reporter: ftang, Assigned: tetsuroy)
Details
Attachments
(7 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
application/octet-stream
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
We should move "UTF-8" , "ISO-8859-1", "windows-1252" and "x-mac-roman"
converters from ucvlatin to uconv so ucvlatin.dll won't load into memory for the
top 100 English URLs. This way we can save some footprint (~100K ) in windows.
Currently, ucvlatin is 180K in windows and if we can make sure ucvlatin is not
loaded into memory for the top 100 URL then we can save those space.
Reporter | ||
Comment 1•24 years ago
|
||
We probably can save up to 50K of footprint for English user on top 100 URL by
doing this work . Mark it as P1 and moz 0.8
Target Milestone: --- → mozilla0.8
Assignee | ||
Updated•24 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•24 years ago
|
||
Assignee | ||
Comment 4•24 years ago
|
||
Assignee | ||
Comment 5•24 years ago
|
||
Assignee | ||
Comment 6•24 years ago
|
||
nhotta< I removed files from uconv/ucnlatin and added some to uconv/src. Can you
update the Mac makefile for me? Thanks
Assignee | ||
Comment 7•24 years ago
|
||
Verified ucvLatin.dll won't get loaded after executing chofmann's top 100 site
list. :0 Saving of 180KB in the debug build.
Assignee | ||
Comment 8•24 years ago
|
||
Once this bug is checked in, we can remove ucvlatin.dll from embedding makefile.
Assignee | ||
Comment 9•24 years ago
|
||
ftang: can you review the code for me? Thanks
Assignee | ||
Comment 10•24 years ago
|
||
bstell< can you verify the patch on Unix?
1) please make sure patch compiles the build
2) launch mozilla and view few URLs to see if it renders correctly for latin1.
Thanks
Assignee | ||
Comment 11•24 years ago
|
||
Assignee | ||
Comment 12•24 years ago
|
||
ftang< can we review the patch again? Thanks
Reporter | ||
Comment 13•24 years ago
|
||
sr=ftang on the new patch. Make sure you test it on linux and Mac before you
check in.
Assignee | ||
Comment 14•24 years ago
|
||
bstell< can you review my patches for Linux?
nhotta< can you review my patches for Mac?
Assignee | ||
Comment 15•24 years ago
|
||
Assignee | ||
Comment 16•24 years ago
|
||
Jud: can you /r= my patch?
I have bstell tested the build on Linux and nhotta tested on Mac.
Comment 17•24 years ago
|
||
I install the patch on linux and it builds and runs okay.
Assignee | ||
Comment 18•24 years ago
|
||
Comment 19•24 years ago
|
||
why do you need to manipulate the registry directly like this? doesn't
NSGETMODULE do what you need?
Assignee | ||
Comment 20•24 years ago
|
||
Unfinished module include uconv.dll
(see http://bugzilla.mozilla.org/show_bug.cgi?id=22921)
I am going to covert uconv.dll to use NS_GETMODULE().
Assignee | ||
Comment 21•24 years ago
|
||
ftang: In 22921 <2000-01-10 14:25> comment, you decided to hold off the
conversion. What was Cata's issue?
Assignee | ||
Comment 22•24 years ago
|
||
Jud: I am going to reopen (http://bugzilla.mozilla.org/show_bug.cgi?id=22921)
to covert uconv.dll to use NS_GETMODULE(). Do you see any problem check-in
these patches?
Comment 23•24 years ago
|
||
sounds good to me. r=valeski on the 2/5/01 16:02 patch.
Comment 24•24 years ago
|
||
You might want escaped-unicode and MUTF7 as well.
Assignee | ||
Comment 25•24 years ago
|
||
checked-in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 26•24 years ago
|
||
Updated•24 years ago
|
QA Contact: teruko → ylong
Comment 27•24 years ago
|
||
Changed QA contact to ylong@netscape.com.
Comment 28•24 years ago
|
||
Looks like someone didn't get around to actually removing these files from
intl/uconv/ucvlatin/. I filed bug 72308 on duplicate files (I didn't know about
this bug until after I filed).
Assignee | ||
Comment 29•24 years ago
|
||
ftang: Please verify. QA can't verify this fix. :)
QA Contact: ylong → ftang
You need to log in
before you can comment on or make changes to this bug.
Description
•