Closed Bug 65745 Opened 24 years ago Closed 24 years ago

reorganize and reformat theme files

Categories

(SeaMonkey :: Themes, defect, P1)

defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9

People

(Reporter: hewitt, Assigned: hewitt)

References

Details

(Keywords: arch)

Attachments

(5 files)

The current state of the modern and classic themes is messy, especially modern. There is a lack of organization in the file structure, lack of consistency in file names and css formatting, and a whole bunch of extra image files and css rules. This needs to change asap, so here is what I plan to do: 1. delete un-used files - there are several hundred of them) 2. organize files - too many files lopped into the same folder (see themes/modern/global) make it hard to find files you're looking for. 3. re-name image files - image files are too inconsistently named. For instance, if an image represents an active state, it currently may include the words cl, clicked, pressed, etc... We need a standard glossary to use when naming files. 4. consistent css comment styles - it would be nice it files were commented in a consistent way so that the comments helped you quickly scan files and find what you want 5. consistent css formatting - indentation and spacing throughout the css should be uniform throughout the theme
Status: NEW → ASSIGNED
Priority: -- → P1
this is probably beyond the scope of this bug, but... a chrome://package/images/imageName urlspec could be really neat basic organization: package supplies a default image 'imageName' and skins provide replacement images. either overlay to redirect url path or just by having the same name. many themes use the same css and different pictures, if we used this approach, the duplicate css could be omitted.
Keywords: arch
timeless, point well taken, but I disagree. In the case of images that seem to be needlessly duplicated in each theme (like, say the mailnews smiley icons or pane-layout image), it's better to give theme designers the ability to change these in their theme if they so desire. If the package owner wishes to hard-code the images, then they should just be included in with the content.
Themes Triage Team nsbeta1+
Keywords: nsbeta1
Target Milestone: --- → mozilla0.9
6. get rid of hundreds of redundant or unnecessary style rules?
I've spent the last week cleaning up and re-organizing the css and image files in the Modern theme. It was often tempting to make XUL changes to help clean up the theme CSS even more, but I tried to keep these changes to a minimum. Lots of XUL-related cleanup will happen in future bugs. I did, however, have to make a small number of XUL changes in xpfe/global, mail, editor, and xpinstall. I'll post these changes as a patch and request review from each of those component owners. As far as the patch to the modern theme goes.... MUAHAHAHA! There will be no patch, the changes are too widespread. Instead, I will simply give you the newly packaged modern.jar. I'd like as many people as possible to open up the jar and give me some feedback on the new organization. Most files have been renamed, moved, and re-organized internally. In addition to organization, I've gotten rid of tons of unnecessary rules and simplified some overly complex rules. I've done quite a bit of testing to make sure I haven't caused any regressions, and so far everything looks good. I'd appreciate as much testing in this area as possible by reviewers.
Attached patch xul patch (for global) (deleted) — Splinter Review
Attached patch xul patch (for mail) (deleted) — Splinter Review
Attached patch xul patch (for editor) (deleted) — Splinter Review
Attached patch xul patch (for xpinstall) (deleted) — Splinter Review
Attached file modern.jar (deleted) —
r=dveditz for xpinstall xul
For editor: Why the big block of lines deleted, then inserted in the middle? There doesn't seem to be any change between those lines. It would be best if you didn't touch those lines if theres no change. Otherwise, r=cmanske. FYI, I use this for diffs: cvs diff -u -w
Actually, there was a reason for the deleted lines. Previously there was a menubar and toolbar free floating, but I put them inside a toolbox. CVS interpreted this as a total deletion because I also re-indented the menubar/toolbar to suit their new nested position.
Be cautious using the -w diff option, it often leads to patches that won't apply correctly and certainly results in a file that no one else could check-in due to whitespace munging.
This stuff looks great. Some comments: - Some people prefer using <vbox .../> over <box orient="vertical"/> - Horizontal is the default box orientation, so no need to explicitly specify it - It seems like a large skip to go from /global to specific widget directories (e.g. /global/tabcontrol). I was thinking perhaps a /widget layer would be better organized, but I suppose it's fine as is if there's nothing else floating around in /global. - I'm not sure about the clarity of the icon# naming convention. Any chance for a more descriptive name? - You didn't give the same lovin' to Classic :-) Otherwise, things look good. Thanks for doing this, r=blake
> It seems like a large skip to go from /global to specific widget directories Since global itself is 99% widgets, having just a /widget subdirectory would be sort of useless. I've always found it to be painful trying to find image files in global, and splitting them up by widget seems to be the best way to make it easier. > I'm not sure about the clarity of the icon# naming convention. I agree, but I've yet to think of a name that sounds just right. Any ideas? > You didn't give the same lovin' to Classic :-) I had intended to, but Ben told me not to.
r=chuang for mail. Sorry for the late review, I just get back from vacation.
r=andreww for modern.jar. I didnt find any style rules for hbox or vbox in box.css. Do they need to be included anywhere?
Blocks: 67848
Blocks: 66219
Blocks: 67753
Blocks: 67410
Blocks: 63624
Blocks: 64252
Blocks: 68082
Blocks: 56218
Blocks: 67763
All fixed for the Modern theme. Whether I ever do Classic remains to be seen.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Marking verified (2001-03-19-12-Mtrunk).
Status: RESOLVED → VERIFIED
after checkins on the 15th these files in mozilla/themes/modern/editor/icons all have a size of 0 byte: align-act.gif align-dis.gif align-hov.gif align.gif When updating from CVS i don't see any signs that these files are reduntant. Have i done something wrong?
also: a file that was updated on the 15th is not readable or are reported corrupted when i try to open it with both the Gimp, ImageMagick and XView: mozilla/themes/modern/communicator/bookmarks/location.gif
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: