Closed Bug 65937 Opened 24 years ago Closed 24 years ago

Pressing Create Profile gives JavaScript error in console

Categories

(SeaMonkey :: Startup & Profiles, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: bugzilla, Assigned: bugs)

Details

Attachments

(2 files)

If you start the profile manager with the console and javascript strict option on, when you press the Create Profile.. button the console says: JavaScript error: chrome://global/content/wizardHandlerSet.js line 157: controls has no properties
if ("controls" in document) { } is better than if (document.controls) and avoids a js warning otherwise, a=ben@netscape.com
Attached patch Patch with Ben's suggestion (deleted) — Splinter Review
Modified patch checked in. Thanks.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
That last patch has tabs where it should not. Super-style nit: doesn't if ('controls' in doc) set the property name off from other (non-property-name) strings, which normally use "" rather than ''? '' is equivalent in JS, provided for two-level quote nesting only, but stylistically useful to make keywords and identifiers stand out from mundane strings. Just a thought. /be
The fix I checked in fixed those nits.
verified in build 2000020904
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: