Closed
Bug 65937
Opened 24 years ago
Closed 24 years ago
Pressing Create Profile gives JavaScript error in console
Categories
(SeaMonkey :: Startup & Profiles, defect)
SeaMonkey
Startup & Profiles
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: bugzilla, Assigned: bugs)
Details
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
If you start the profile manager with the console and javascript strict option
on, when you press the Create Profile.. button the console says:
JavaScript error:
chrome://global/content/wizardHandlerSet.js line 157: controls has no properties
Assignee | ||
Comment 2•24 years ago
|
||
if ("controls" in document) {
}
is better than if (document.controls) and avoids a js warning
otherwise, a=ben@netscape.com
Comment 4•24 years ago
|
||
Modified patch checked in. Thanks.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 5•24 years ago
|
||
That last patch has tabs where it should not.
Super-style nit: doesn't if ('controls' in doc) set the property name off from
other (non-property-name) strings, which normally use "" rather than ''? '' is
equivalent in JS, provided for two-level quote nesting only, but stylistically
useful to make keywords and identifiers stand out from mundane strings. Just a
thought.
/be
Comment 6•24 years ago
|
||
The fix I checked in fixed those nits.
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•