The Safe Form Fill is not quite working because the OK (and the cancel) button is not firing. I'm getting a javascript error at the console top.frames[button_frames].document.buttons.xxxbuttonxxx has no properties htmldlgs.htm line 134 when I click on it. The Safe Form Fill screen comes up correctly with the entries prefilled. Using 5/16 builds. To reproduce: 1. Edit - Wallet - Samples and prefill in some data. 2. Edit - Wallet - Samples - and click on amazon.com 3. Edit - Wallet - Safe Form Fill 4. Click OK Results: Javascript error at console, display is not dismissed. Expected Results: Display is dismissed and forms are filled in.

Several points: 1. The above statement of "expected result: display is dismissed" is not valid. It will be true someday if ever we get modal dialogs. But for now, in my simulation of modal dialogs there is no way that I can close the preview window. 2. Once the OK or cancel button is pressed, the window must be manually closed to simulate the actions of a true modal dialog. Otherwise the user will be inclined to press the buttons a second time and this is totally incorrect -- it will result in the javascript error noted in this bug report. But this error can never occur in a true modal dialog with the display disappearing after OK or cancel are pressed. I was aware of this problem and wanted to at least erase everything in the window since I couldn't close it. But that hit another bug in layout and I had to abandon that idea. I must apologize for all these cludges but I am working with a very lame infrastructure with crucial pieces like modal dialogs missing and what does exist such as layout being full of bugs. 3. After pressing OK or cancel (only once), the values in the form do get prefilled. At least they do for me when I test it out. Based on these points, I am closing this bug report as invalid.

We are not having a good day. On your points: 1. Okay, no problem. For curiosity, how does the preference pane do this? 2. You are correct, it is the second time pressing that causes the js error. 3. Unfortunately, my forms are not being filled in on the first click. Quickfill works fine. I have wallet.useDialogs set to false. Is there anything I am missing?

1. I don't know how the preference pane does it. I am looking into the implementation of the preference pane and might use its dialog facility for my dialogs. But that's just a pipe-dream now. 2. Glad I got this one right. 3. No, there's nothing else that you are missing. Strange that it works for me.

Good catch, cookies need to be enabled for this to work. Enabling cookies makes this work much better.