Closed Bug 660257 Opened 14 years ago Closed 14 years ago

Fix privacy policy validation on channels newsletter form

Categories

(www.mozilla.org :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jlong, Assigned: jlong)

References

()

Details

We missed a revision when rolling out the channels page which makes sure the user checked the "privacy" field in the newsletter signup. It's also missing an error message if they don't. The privacy checkbox is highlighted red but there should a message saying "Please agree to the Privacy Policy" or something like that. This is done by adding a div with the id "privacy-error" below the privacy field. The css should already be in place to show/hide it appropriately.
Assignee: nobody → jlong
Target Milestone: --- → 2.6
The revision fix for validating the privacy field: trunk in r89503 stage in r89504
Also, I noticed the checkboxes for the newsletter channels weren't being kept if an error occurred on the form. I thought I remembered testing that... I fixed that too.
pushed to trunk r89507 So things to test: * Go to the newsletter signup in the bottom of page * Make sure the privacy policy must be checked (fill in all other info, submit) * Make sure there's an error message for the privacy field * Make sure the newsletter checkboxes are checked the same way after an error
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: qawanted
Resolution: --- → FIXED
small fix in r89515
Blocks: 658665
pushed to production r89683
Status: RESOLVED → VERIFIED
Component: www.mozilla.org/firefox → www.mozilla.org
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.