Closed Bug 6623 Opened 26 years ago Closed 25 years ago

no comma between cclist and tolist in processmail "email sent to" output

Categories

(Bugzilla :: Bugzilla-General, defect, P5)

Other
Other
defect

Tracking

()

VERIFIED FIXED
Bugzilla old

People

(Reporter: ian, Assigned: terry)

References

()

Details

(Whiteboard: suggested fix included)

I feel silly even bothering to report this, but on line 271 of processmail, http://lxr.mozilla.org/mozilla/source/webtools/bugzilla/processmail#271 ...the $tolist and $cclist variables are printed like this: print "<B>Email sent to:</B> $tolist $cclist\n"; ...which means that the output can look like this: Email sent to: me, you someone-else, a.n.other Note the lack of a comma between "you" and "someone-else". I suggest this be marked WONTFIX, but if you have some spare cycles then you may wish to pretty print the list instead. The easiest way to do this would be to replace lines 271 to 274 with the following: print "<STRONG>Email sent to:</STRONG> $tolist"; if ($tolist ne "") and ($cclist ne "") { print ","; } print " $cclist\n"; if ($didexclude) { print "<BR><STRONG>Excluded:</STRONG> $nametoexclude (<a href=changepassword.cgi>change your preferences</a> if you wish not to be excluded)\n"; } (I hope my perl is correct. Most notably, I hope the syntax of the if statement is correct.)
Priority: P3 → P5
Whiteboard: suggested fix included
Status: NEW → ASSIGNED
Oh, I'll fix it. Someday.
Note. Lines 271 to 274 are these: 270 $logstr = "$logstr; mail sent to $tolist, $cclist"; 271 print "<B>Email sent to:</B> $tolist $cclist\n"; 272 if ($didexclude) { 273 print "<B>Excluding:</B> $nametoexclude (<a href=changepassword.cgi>change your preferences</a> if you wish not to be excluded)\n"; 274 } Just in case the file changes... ;-)
I happen to have fixed this as a side result of some rather severe damage I'm doing to the email notification code.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
per Terry, auto-verifying any resolved bug that hasn't been touched since before 2.10 was released.
Status: RESOLVED → VERIFIED
Moving to Bugzilla product
Component: Bugzilla → Bugzilla-General
Product: Webtools → Bugzilla
QA Contact: matty
Target Milestone: --- → Bugzilla old
Version: other → unspecified
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.