Closed
Bug 662599
Opened 13 years ago
Closed 13 years ago
Allow cross-domain textures with CORS approval
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
People
(Reporter: bjacob, Assigned: joe)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, Whiteboard: [qa-])
Since bug 656277 landed, cross-domain WebGL textures are no longer allowed. That, sadly, breaks useful content (bug 662570).
We now have to code the code allowing cross-domain textures when they have CORS approval.
Reporter | ||
Comment 1•13 years ago
|
||
WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=61015
Reporter | ||
Updated•13 years ago
|
OS: Linux → All
Hardware: x86_64 → All
Comment 3•13 years ago
|
||
Broken AngryBirds was duped here so I'm carrying over our tracking Firefox 6 status to this bug.
I'm guessing that we're not going to get this fixed for 6 but I just want to make sure that the drivers don't lose this after the duping.
tracking-firefox6:
--- → +
Reporter | ||
Comment 4•13 years ago
|
||
(In reply to comment #3)
> I'm guessing that we're not going to get this fixed for 6 but I just want to
> make sure that the drivers don't lose this after the duping.
I really, absolutely want to have this fixed in 6! Only reason why it's not done already is the crazy WebGL events of the past week + many bug reports to handle. If I'm not fast enough, perhaps someone more competent wants to take this. On the WebKit side they had their big gurus working on it immediately and got it done very fast.
Updated•13 years ago
|
tracking-firefox7:
--- → +
Assignee | ||
Comment 5•13 years ago
|
||
Bug 664299 contains an implementation of this, and is now inbound.
The dev-doc-needed here is that we now allow cross-origin images that have the crossorigin attribute specified and been verified with CORS.
Assignee: nobody → joe
Keywords: dev-doc-needed
Assignee | ||
Comment 6•13 years ago
|
||
Bug 664299 has been merged to m-c!
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Windows 7 x64
Firefox 8.0a1 x64
NOT fixed
http://i1.imageban.ru/out/2011/07/15/3cbdb7b103c648c695b4cecc9bd02869.png
Reporter | ||
Comment 8•13 years ago
|
||
Angry Birds is working fine now. Apparently they only started using CORS recently, as until recently it also failed in Chrome 14.
Comment 9•13 years ago
|
||
Documentation updated:
https://developer.mozilla.org/en/WebGL/Using_textures_in_WebGL
https://developer.mozilla.org/en/WebGL/Cross-Domain_Textures
Also updated Firefox 7 for developers, and added a link to the Cross-domain textures article on the main WebGL landing page.
Keywords: dev-doc-needed → dev-doc-complete
Reporter | ||
Comment 10•13 years ago
|
||
Thanks a bunch. I didn't even know that we had this HTTP Access Control wiki page.
Reporter | ||
Comment 11•13 years ago
|
||
I've made some changes to https://developer.mozilla.org/en/WebGL/Cross-Domain_Textures mostly to reflect the fact that it's only in Gecko 8 that CORS support for WebGL textures and the crossOrigin attribute for images is implemented. Please review, especially I'm not sure about the usage of the macros there.
Comment 12•13 years ago
|
||
Hm, okay. It's flagged in the writing team's records as being in Firefox 7, so this is good to know. Thanks!
Reporter | ||
Comment 13•13 years ago
|
||
Also I've taken the canvas remark out of the Gecko 5-6-7 note. It will always be true that tainted canvases can't be used as WebGL textures. I believe, but am not sure, that we want to add CORS support to canvas drawImage too to allow painting CORS-approved cross-domain images onto a canvas without tainting it; but that isn't implemented yet (last time I checked).
Reporter | ||
Comment 14•13 years ago
|
||
(In reply to Eric Shepherd [:sheppy] from comment #12)
> Hm, okay. It's flagged in the writing team's records as being in Firefox 7,
> so this is good to know. Thanks!
Sorry about that. For a long time we hoped to get it into Firefox 7, but didn't manage to. It really is a Firefox 8 thing.
Comment 15•13 years ago
|
||
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0
Can anyone please help me with a test case or with STR/guidelines in order to get this issue checked on QA side?
Thanks!
Comment 16•13 years ago
|
||
It has been decided we won't take this in Firefox 7.
status-firefox7:
--- → wontfix
Comment 17•13 years ago
|
||
Should this be fixed in Firefox 8? I'm on Aurora 2011-09-19 and https://developer.mozilla.org/en-US/demos/detail/webgl-earth/launch still doesn't work.
Reporter | ||
Comment 18•13 years ago
|
||
Yes it's fixed in 8. See the unit test (in 8 it's in content/canvas/test/webgl/crossorigin, in 9 it's in content/canvas/test/crossorigin).
This demo seems like it just doesn't use CORS? Hard to say as this JS code is obfuscated/minified.
You need to log in
before you can comment on or make changes to this bug.
Description
•