Closed
Bug 6665
Opened 26 years ago
Closed 26 years ago
Sorting causes my message resources to be deleted
Categories
(Core Graveyard :: RDF, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
M7
People
(Reporter: scottputterman, Assigned: waterson)
Details
(Whiteboard: fix ready to go.)
I'm not sure if this is a bug, but I don't think this should be happening. RDF
has the only reference to my message resources. When a sort occurs, they are
all getting released and therefore deleted. This causes other problems for me
(it's my fault these problems occur, not yours, but if they weren't getting
deleted, you'd fix my problems :) ).
Anyway, they are getting deleted in:
RDFElementImpl::SetDocument(RDFElementImpl * const 0x0446da50, nsIDocument *
0x00000000, int 1) line 1365
RDFElementImpl::RemoveChildAt(RDFElementImpl * const 0x0443bfb0, int 13, int 0)
line 1631
XULSortServiceImpl::RemoveAllChildren(nsIContent * 0x0443bfb0) line 644
XULSortServiceImpl::SortTreeChildren(nsIContent * 0x0443bfb0, int 0, _sortStruct
* 0x0012e4a4, int 0) line 1037
XULSortServiceImpl::DoSort(XULSortServiceImpl * const 0x03f5a480, nsIDOMNode *
0x03fa2dd0, const nsString & {"http://home.netscape.com/NC-rdf#Subject"}, const
nsString & {"ascending"}) line 1361 + 27 bytes
nsRDFCore::DoSort(nsRDFCore * const 0x045491e0, nsIDOMNode * 0x03fa2dd0, const
nsString & {"http://home.netscape.com/NC-rdf#Subject"}, const nsString &
{"ascending"}) line 159
when
nsCOMPtr<nsIRDFResource> resource;
GetResource(getter_AddRefs(resource));
goes out of scope.
Assignee | ||
Updated•26 years ago
|
Assignee: rjc → waterson
Assignee | ||
Updated•26 years ago
|
Status: NEW → ASSIGNED
Target Milestone: M7
Assignee | ||
Comment 1•26 years ago
|
||
So we can fix this by forcing the sort code to take ownership of each
_resource_ (as well as each node) before removing the node from the content
model to sort.
This is probably a decent optimization to make, as I believe that it'll happen
with other resources as well.
Heck, I'll even take the bug.
Assignee | ||
Updated•26 years ago
|
Whiteboard: fix ready to go.
Assignee | ||
Updated•26 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 2•26 years ago
|
||
Pile on! Fix checked in.
Reporter | ||
Comment 3•26 years ago
|
||
Chris. Thanks for checking this in. I'll try it out with tomorrow's builds.
Reporter | ||
Updated•26 years ago
|
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 5•26 years ago
|
||
It looks like this is working. Marking verified.
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•