We ran into this in 6.0b1. The workdir was wrong, but the step finished and exited 0. It doesn't matter if there are a ton of ERROR lines if no one parses that before moving on.

In bug 574764 I've added haltOnFailure: https://bugzilla.mozilla.org/attachment.cgi?id=543758&action=diff&headers=1#a/process/factory.py_sec4 You may want to just add a dependency to bug 574764.

Dependency added. multil10n.py and maemo_multi_locale_build.py still need to exit non-0 if there are errors.

* Added |self.return_code = 0| to BaseScript.__init__(); any step can modify self.return_code on error. * The original reason I filed this bug was because the cwd specified in a run_command() call didn't exist. This defaulted to a self.error(); now modified to self.fatal() if halt_on_failure=True. Also added this change to self.get_output_from_command(). * Got rid of some trailing whitespace. * Modified MultiLocaleBuild.add_locales() to check for status on the |make chrome-LOCALE| step. Added summaries; incremented self.return_code on failure. Example output when I moved l10n-central/ru away: <snip> 11:32:01 ERROR - make[2]: *** [chrome] Error 2 11:32:01 INFO - make[2]: Leaving directory `/builds/slave/aki/build/obj-firefox/toolkit/locales' 11:32:01 ERROR - make[1]: *** [chrome-ru] Error 2 11:32:01 INFO - make[1]: Leaving directory `/builds/slave/aki/build/obj-firefox/toolkit/locales' 11:32:01 INFO - make: *** [chrome-ru] Error 2 11:32:01 ERROR - Return code: 2 11:32:01 ERROR - Failed to add locale ru! 11:32:01 INFO - ##### 11:32:01 INFO - ##### Skipping package-multi step. 11:32:01 INFO - ##### 11:32:01 INFO - ##### 11:32:01 INFO - ##### Skipping upload-multi step. 11:32:01 INFO - ##### 11:32:01 INFO - ##### 11:32:01 INFO - ##### MultiLocaleBuild summary: 11:32:01 INFO - ##### 11:32:01 INFO - Added locale cs successfully. 11:32:01 INFO - Added locale da successfully. 11:32:01 INFO - Added locale de successfully. 11:32:01 INFO - Added locale es-ES successfully. 11:32:01 INFO - Added locale fi successfully. 11:32:01 INFO - Added locale fr successfully. 11:32:01 INFO - Added locale ja successfully. 11:32:01 INFO - Added locale it successfully. 11:32:01 INFO - Added locale nb-NO successfully. 11:32:01 INFO - Added locale nl successfully. 11:32:01 INFO - Added locale pl successfully. 11:32:01 INFO - Added locale pt-PT successfully. 11:32:01 ERROR - Failed to add locale ru! [cltbld@linux-ix-slave05 aki]$ echo $? 1

Comment on attachment 559260 [details] [diff] [review] multilocale step should exit non-zero on failure http://hg.mozilla.org/build/mozharness/rev/742ae89e8074