Problems discovered by static analysis and patched by hand. Reviewers this round: bz: content/base/src/nsGenericElement.cpp | 2 +- content/base/src/nsLineBreaker.cpp | 4 ++-- docshell/base/nsDocShell.cpp | 4 ++-- layout/xul/base/src/nsListBoxBodyFrame.cpp | 2 +- layout/xul/base/src/nsMenuPopupFrame.h | 2 +- ehsan: editor/libeditor/html/nsHTMLEditRules.cpp | 2 +- editor/libeditor/html/nsHTMLEditRules.h | 2 +- editor/libeditor/html/nsTableEditor.cpp | 4 ++-- dwitte: extensions/cookie/nsCookiePermission.cpp | 5 +++-- bholley: gfx/thebes/gfxPlatform.cpp | 2 +- vlad: intl/uconv/src/nsUTF8ToUnicode.cpp | 2 +- luke: js/src/jstracer.cpp | 2 +- js/src/methodjit/StubCalls.cpp | 2 +- biesi: netwerk/base/src/nsLoadGroup.cpp | 4 ++-- mak: toolkit/components/places/nsNavHistoryResult.h | 2 +- roc: widget/src/xpwidgets/nsPrintSettingsImpl.cpp | 2 +- widget/src/xpwidgets/nsPrintSettingsImpl.h | 2 +-

Comment on attachment 545750 [details] [diff] [review] Fix Review of attachment 545750 [details] [diff] [review]: -----------------------------------------------------------------

Comment on attachment 545750 [details] [diff] [review] Fix >+++ b/content/base/src/nsLineBreaker.cpp You need to change nsLineBreaker.h too. >+++ b/docshell/base/nsDocShell.cpp >+static PRUint32 gValidateOrigin = 0xffffffff; Excellent. We couldn't do this before for some reason.... >+++ b/layout/xul/base/src/nsMenuPopupFrame.h >+ PRInt8 mConsumeRollupEvent; // Should the rollup event be consumed? You need to change the constructor so that initialization order matches declaration order. Also, fix the comment? Perhaps to say that it's one of nsIPopupBoxObject::ROLLUP_DEFAULT/ROLLUP_CONSUME/ROLLUP_NO_CONSUME ? r=me on my part with the above nits.

Comment on attachment 545750 [details] [diff] [review] Fix Clearing review for the netwerk part because (nssupportsarray)AppendElement doesn't actually return nsresult, as bz points out. Will open another bug to fix that insanity.

Comment on attachment 545750 [details] [diff] [review] Fix r+ for nsUTF8ToUnicode (can I even r+ that? I know the original/changed code was mine...)

Comment on attachment 545750 [details] [diff] [review] Fix r=me for the editor parts.

Comment on attachment 545750 [details] [diff] [review] Fix Review of attachment 545750 [details] [diff] [review]: -----------------------------------------------------------------

Comment on attachment 545750 [details] [diff] [review] Fix Review of attachment 545750 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/thebes/gfxPlatform.cpp @@ +927,4 @@ > #define INTENT_MIN 0 > #define INTENT_MAX 3 > > +int This needs to be changed in gfxPlatform.h too.

Comment on attachment 545750 [details] [diff] [review] Fix Review of attachment 545750 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/thebes/gfxPlatform.cpp @@ +927,4 @@ > #define INTENT_MIN 0 > #define INTENT_MAX 3 > > +int gfxPlatform.h already specifies this as int, AFAICT.