In prefs under modern, most controls get blue borders when they're focused. The borders seem to be broken/transparent at the top right of textboxes and buttons (but not most other controls).

This has to do with the crappy implementation of -moz-border-radius, which draws really ugly "rounded" corners when the radius is any greater than 3px. It would probably make sense for us to thin out the focus border on textfields, buttons, and menulists (especially textfields) to make the rounded borders look a little cleaner.

I don't know exactly how the widgets are rendered, but possibly the method I used for my own custom controls would work (for the same reason). Render the focus border as 1 pixel thicker than you need it, so that roughly 1 pixel of it is *inside* the area where the actual text field/button will be. Then render the text field or button over this. This way, you don't have to worry about the slight errors when doing rounded corners.

The current focus looks awful. Hewitt, please fix this for 0.9!

I agree whole-heartedly. I don't know what we were thinking when we made widgets use such a wide -moz-border-radius on focus. We'll definitely clean it up for mozilla0.9

This is now partially fixed. I just checked in polish for the focus effects on textfield. Other widgets will follow when I land the modern cleanup bug (bug 65745).

Much prettier now :) fixed.

Marking verified on windows (2001-03-19-12-Mtrunk).