Closed
Bug 674230
Opened 13 years ago
Closed 13 years ago
Land qcms LUT support with Pref
Categories
(Core :: Graphics: Color Management, defect)
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: BenWa, Assigned: BenWa)
References
Details
Attachments
(3 files, 3 obsolete files)
(deleted),
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
The goal is to land new qcms ICC v4 features such as CLUT support on m-c with a preference to enable them.
Assignee | ||
Comment 1•13 years ago
|
||
Assignee | ||
Comment 2•13 years ago
|
||
Feel free to nit pick about the name.
Waiting for tryserver results before flagging review.
Assignee | ||
Updated•13 years ago
|
Attachment #548543 -
Attachment is patch: true
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #548768 -
Flags: review?(jmuizelaar)
Assignee | ||
Comment 4•13 years ago
|
||
Attachment #548542 -
Attachment is obsolete: true
Attachment #548543 -
Attachment is obsolete: true
Attachment #548770 -
Flags: review?(jmuizelaar)
Assignee | ||
Comment 5•13 years ago
|
||
Updated•13 years ago
|
Attachment #548768 -
Flags: review?(jmuizelaar) → review+
Comment 6•13 years ago
|
||
Comment on attachment 548770 [details] [diff] [review]
Part 2: Add gfx.color_management.force_v4
I don't really see the point of CMVersionFourPrefName. The only thing I can think of is to keep all of the different prefs close together. However, I think documentation would serve this just as well.
I suggest just using the name directly. I'd also take a patch to inline all of the other names.
Attachment #548770 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Comment 7•13 years ago
|
||
Carrying forward r+
Attachment #548770 -
Attachment is obsolete: true
Assignee | ||
Comment 8•13 years ago
|
||
Whiteboard: [inbound]
Assignee | ||
Comment 9•13 years ago
|
||
Attachment #548885 -
Flags: review?(jmuizelaar)
Updated•13 years ago
|
Attachment #548885 -
Flags: review?(jmuizelaar) → review+
Comment 10•13 years ago
|
||
Assignee: nobody → bgirard
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
Comment 11•13 years ago
|
||
Comment 12•13 years ago
|
||
Assignee | ||
Comment 13•13 years ago
|
||
I just tested with the following profile: http://www.colorkeeper.com/?page_id=235
We get the un managed result without v4 and the perceptual with the v4 pref. I would of expected to get the TRC result however we are less strict with the profiles we reject now.
The profile in the package is very interesting. It shows very obviously what is being managed and what is not (i.e. the browser chrome).
Updated•12 years ago
|
Depends on: CVE-2012-1960
Comment 14•7 years ago
|
||
I just stumbled across this feature when visiting http://cameratico.com/tools/web-browser-color-management-test/ and noticing the "v4" brokenness there in Firefox. (though it works if I toggle this bug's pref & restart Firefox)
Does anyone recall why this feature was pref-controlled & preffed-off-by-default? i.e. was there some remaining work to be done before it could be enabled? Or was the feature known-to-be-permanently-problematic so we wanted to make it opt in? Or something else?
Flags: needinfo?(jmuizelaar)
Comment 15•7 years ago
|
||
Performance isn't great and there might be security problems.
Flags: needinfo?(jmuizelaar)
You need to log in
before you can comment on or make changes to this bug.
Description
•