Closed Bug 67527 Opened 24 years ago Closed 24 years ago

clean up psm module registration

Categories

(Core Graveyard :: Security: UI, defect)

1.0 Branch
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: bryner, Assigned: bryner)

Details

Attachments

(1 file)

There are a few problems currently with the component registration in both psm-glue and pipnss: - The entropy collector is registered with the same factory constructor as the other nsNSSComponent stuff, but a different CID. This causes the service manager to unknowingly create multiple instances of the component. There should be only one CID per class (not per interface), and it should live in the implementation, not in the idl. - We register NS_SECURE_DOCOBSERVER_CONTRACTID, which as far as I can tell is not used, anywhere. - Fix misspelling HANDLER -> HANLDER
Attached patch patch (deleted) — Splinter Review
Status: NEW → ASSIGNED
How is the secure browser UI comonent registered now? I saw you take it's registration, but don't see how it gets registered again.
The secure browser UI component was previously being registered under two contractids: NS_SECURE_BROWSER_DOCOBSERVER_CONTRACTID (unused) NS_SECURE_BROWSER_UI_CONTRACTID (used) I simply removed the first one.
Patch looks good, r=javi.
checked in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Verified per Brian's comments.
Status: RESOLVED → VERIFIED
Product: PSM → Core
Version: psm2.0 → 1.0 Branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: