Closed Bug 679938 Opened 13 years ago Closed 12 years ago

report whether firefox is the default browser

Categories

(Toolkit :: Telemetry, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: taras.mozilla, Assigned: taras.mozilla)

References

Details

Attachments

(1 file)

      No description provided.
Sid, this is ok with you, right?
Attachment #556719 - Flags: review?(mh+mozilla)
Comment on attachment 556719 [details] [diff] [review]
defaultbrowser simple measurement

Review of attachment 556719 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/TelemetryPing.js
@@ +193,4 @@
>    var ret = {
>      // uptime in minutes
> +    uptime: Math.round((new Date() - si.process) / 60000),
> +    defaultBrowser: defaultBrowser * 1

I'd use Number(defaultBrowser) instead to make the intent clearer.

r=me with the above. As a bonus, I'd add a comma at the end of this line, so that further additions only require adding lines, and not modifying the previous one.
Attachment #556719 - Flags: review?(mh+mozilla) → review+
Depends on: 685373
Since bug 685373 landed, privacy review is resolved. 
https://wiki.mozilla.org/Privacy/Reviews/Telemetry/Default_Browser_Status
Assigning to Taras; would be nice to get this landed.
Assignee: nobody → taras.mozilla
We do not have a clear need for this.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: