Closed Bug 6803 Opened 26 years ago Closed 20 years ago

Remove AddRef/Release references in TextServices

Categories

(Core :: DOM: Editor, defect, P3)

defect

Tracking

()

RESOLVED WORKSFORME
Future

People

(Reporter: kinmoz, Assigned: kinmoz)

Details

(Keywords: helpwanted, perf)

Modify the TextServices module to keep raw pointers to the PresShell, DOMDocument and editor, instead of references. This will help cut down any chances of leaking the entire document, etc.
Status: NEW → ASSIGNED
Target Milestone: M8
Accepting bug, setting milestone to M8
Changing milestone to M9 since I don't have time to look at spellchecker issues yet.
Moving all spellchecker/text services related bugs to M11 since I will still be working on AutoComplete features through M10.
Moving some SpellChecker/TextServices feature requests and bugs, that can wait till after beta 1, to milestone M14.
moving to M16 per comments by Kin (post-beta1)
Target Milestone: M14 → M16
moving to m17
Target Milestone: M16 → M17
Move to M18. Doesn't look like I'll get a chance to visit this for M17.
Target Milestone: M17 → M18
needs to be done to avoid potential leaking of the entire document, there is the potential to not destroy the text services document, which would result in the leak.
Keywords: correctness
Target Milestone: M18 → M19
adding performance keyword
Keywords: perf
moving to future, adding helpwanted
Keywords: helpwanted
Target Milestone: M19 → Future
It appears that nsTextServicesDocument.h now uses nsCOMPtr<>s. The original intent of this bug looks like it was to prevent leaks, so it seems this bug can now be closed.
Closing according to comment 11 from caillon.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 20 years ago20 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.