Closed
Bug 68064
Opened 24 years ago
Closed 24 years ago
Initial click on named anchor unselects that item in link properties
Categories
(Core :: DOM: Editor, defect, P3)
Core
DOM: Editor
Tracking
()
VERIFIED
FIXED
mozilla0.9
People
(Reporter: sujay, Assigned: cmanske)
Details
Attachments
(3 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
using 2/7 build of netscape
1) launch netscape
2) launch composer
3) insert text ("hello world")
4) hit carriage return
5) insert named anchor "foo"
6) highlight "hello world"
7) bring up link props
click on "foo" in named anchor list
it doesn't select the first time.
you have to click on "foo" again to select it.
all platforms.
Comment 1•24 years ago
|
||
Sujay and I both saw this one, assigning to cmanske
Assignee: beppe → cmanske
Priority: -- → P3
Target Milestone: --- → mozilla0.9.1
Assignee | ||
Comment 2•24 years ago
|
||
Assignee | ||
Comment 3•24 years ago
|
||
Simple fix is ready.
Status: NEW → ASSIGNED
Whiteboard: FIX IN HAND
Target Milestone: mozilla0.9.1 → mozilla0.9
Comment 5•24 years ago
|
||
sr=sfraser
Assignee | ||
Comment 6•24 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
still not fixed...just tried it on 2/26 build.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 8•24 years ago
|
||
This is really a different bug than original, so I change the summary.
Clicking on a named anchor takes the name and appends it to "#" in the Location
(href) input field, but unselects the named anchor in the list, which is
confusing to user. Easy to fix.
Status: REOPENED → ASSIGNED
Summary: two clicks required on anchor in link props to select it → Initial click on named anchor unselects that item in link properties
Assignee | ||
Comment 9•24 years ago
|
||
Updated•24 years ago
|
Whiteboard: FIX IN HAND; waiting for sr= → FIX IN HAND; waiting for sr= and r=
Comment 10•24 years ago
|
||
Some questions/comments on the 02/28/01 14:00 patch:
1. Avoid double negatives, they can sometimes be confusing:
if(!dontChange)
How 'bout changing the var name to gClearListSelections, reversing the init
value and checking:
var gClearListSelections = true;
...
if (gClearListSelections)
2. Is there a way to avoid using a global? Like making it so you can do
something like dialog.clearListSelections? Not a requirement, but I hate
globals.
3. Fix the indentation of the Unselect calls you are pushing under your new if
statement.
4. Remove the ChangeText() call that you commented out.
Assignee | ||
Comment 11•24 years ago
|
||
There's no advantage to not using "global", which are equivalent to
window.gVariable anyway, and scope to just the dialog's window.
Ok about other comments.
Assignee | ||
Comment 12•24 years ago
|
||
Comment 13•24 years ago
|
||
r=brade
Whiteboard: FIX IN HAND; waiting for sr= and r= → FIX IN HAND; waiting for sr=
Assignee | ||
Comment 14•24 years ago
|
||
checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
Whiteboard: FIX IN HAND; waiting for sr=
Reporter | ||
Comment 15•24 years ago
|
||
verified in 4/19 build.
however there is a new problem in that OK button is not
highlighted after clicking on named anchor in list.
see Bug 76680
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•