Closed
Bug 684662
Opened 13 years ago
Closed 13 years ago
js\src\methodjit/MethodJIT.h(690) : warning C4305: 'argument' : truncation from 'js::MaybeConstruct' to 'bool'
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file)
(deleted),
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
https://tbpl.mozilla.org/php/getParsedLog.php?id=6274862&full=1
d:/mozilla-build/python25/python2.5.exe -O e:/builds/moz2_slave/m-cen-w32/build/js/src/build/cl.py cl -Fojsanalyze.obj -c -DOSTYPE=\"WINNT5.2\" -DOSARCH=WINNT -DEXPORT_JS_API -DIMPL_MFBT -DJS_HAS_CTYPES -DDLL_PREFIX=\"\" -DDLL_SUFFIX=\".dll\" -Ictypes/libffi/include -I. -I/e/builds/moz2_slave/m-cen-w32/build/js/src -I. -I./../../dist/include -I./../../dist/include/nsprpub -Ie:/builds/moz2_slave/m-cen-w32/build/obj-firefox/dist/include/nspr -I/e/builds/moz2_slave/m-cen-w32/build/js/src -I/e/builds/moz2_slave/m-cen-w32/build/js/src/assembler -I/e/builds/moz2_slave/m-cen-w32/build/js/src/yarr -GR- -TP -nologo -wd4345 -D_CRT_SECURE_NO_WARNINGS -W3 -Gy -Fdgenerated.pdb -wd4244 -wd4800 -we4553 -DNDEBUG -DTRIMMED -Zi -Zi -UDEBUG -DNDEBUG -O2 -Oy -DUSE_SYSTEM_MALLOC=1 -DENABLE_ASSEMBLER=1 -DENABLE_JIT=1 -MD -FI ./js-confdefs.h -DMOZILLA_CLIENT /e/builds/moz2_slave/m-cen-w32/build/js/src/jsanalyze.cpp
jsanalyze.cpp
e:\builds\moz2_slave\m-cen-w32\build\js\src\methodjit/MethodJIT.h(690) : warning C4305: 'argument' : truncation from 'js::MaybeConstruct' to 'bool'
Assignee | ||
Comment 2•13 years ago
|
||
Attachment #558229 -
Flags: review?(bhackett1024)
Comment 3•13 years ago
|
||
Comment on attachment 558229 [details] [diff] [review]
fix
Review of attachment 558229 [details] [diff] [review]:
-----------------------------------------------------------------
Can you change the arguments passed to true/false instead?
Attachment #558229 -
Flags: review?(bhackett1024) → review+
Assignee | ||
Comment 4•13 years ago
|
||
land with changing to true/false
http://hg.mozilla.org/integration/mozilla-inbound/rev/e00b68fc6df9
Whiteboard: [inbound]
Assignee | ||
Updated•13 years ago
|
Assignee: general → m_kato
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
You need to log in
before you can comment on or make changes to this bug.
Description
•