Closed Bug 6885 Opened 26 years ago Closed 26 years ago

[PP][CRASH]selecting Bookmarks|Personal Bookamarks crashes when empty

Categories

(Core :: XUL, defect, P3)

x86
All
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: cmaximus, Assigned: saari)

Details

If you select Bookmarks| Personal Bookmarks on WinNT or Linux when your personal bookmarks aren't populated, you crash. this probably isn't a biggie but it should be more graceful. *Build info: WinNT 1999051910, Linux 1999052009. Mac 1999051909 is OKAY. This is Win and Linux ONLY. *To Repro:Launch Seamonkey. Select Bookmarks|Personal Bookmarks. Crash *Expected behavior: The proper, robust, Nova behaviour would be to do absolutely nothing. *Actual results: Crash. I've assigned this to saari because a little birdie told me to do so
Ok, this didn't crash for me. Do you have a stack crawl?
sure do. talkback Incident number 8893979 this is the WinNT crawl: Call Stack: (Signature = 0x00000003 41862fd7) 0x00000003 nsJSUtils::nsConvertObjectToJSVal [d:\builds\seamonkey\mozilla\dom\src\base\nsJSUtils.cpp, line 134] GetEventProperty [d:\builds\seamonkey\mozilla\dom\src\events\nsJSEvent.cpp, line 101] js_GetProperty [d:\builds\seamonkey\mozilla\js\src\jsobj.c, line 1695] js_Interpret [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 2173] js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 671] js_CallFunctionValue [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 736] JS_CallFunctionValue [d:\builds\seamonkey\mozilla\js\src\jsapi.c, line 2439] nsJSEventListener::HandleEvent [d:\builds\seamonkey\mozilla\dom\src\events\nsJSEventListener.cpp, line 98] nsEventListenerManager::HandleEvent [d:\builds\seamonkey\mozilla\layout\events\src\nsEventListenerManager.cpp, line 565] RDFElementImpl::HandleDOMEvent [d:\builds\seamonkey\mozilla\rdf\content\src\nsRDFElement.cpp, line 2255] RDFElementImpl::HandleDOMEvent [d:\builds\seamonkey\mozilla\rdf\content\src\nsRDFElement.cpp, line 2260] raptorwidget.dll + 0xa8b7 (0x012da8b7) raptorwidget.dll + 0xa913 (0x012da913) raptorwidget.dll + 0x761d (0x012d761d) raptorwidget.dll + 0x5fa0 (0x012d5fa0) USER32.dll + 0x1268 (0x77e71268) I have a Mac stack crawl but I think I may have mislabled it or something because this doesn't crash on Mac, just NT and Linux. Here's a Linux crawl: Program received signal SIGSEGV, Segmentation fault. 0x8594180 in ?? () (gdb) bt #0 0x8594180 in ?? () #1 0x402ccb3b in NS_NewScriptEventListener () #2 0x403344b4 in js_GetProperty () #3 0x4032848e in js_Interpret () #4 0x40326dd0 in js_Invoke () #5 0x40326f75 in js_CallFunctionValue () #6 0x40311c99 in JS_CallFunctionValue () #7 0x402cc640 in nsJSEventListener::HandleEvent () #8 0x40963e09 in nsEventListenerManager::HandleEvent () #9 0x4078719d in RDFElementImpl::HandleDOMEvent () #10 0x407871f8 in RDFElementImpl::HandleDOMEvent () #11 0x40099a0a in nsMenuItem::DoCommand () #12 0x40099841 in nsMenuItem::MenuItemSelected () #13 0x4009a566 in menu_item_activate_handler () #14 0x80c41f6 in gtk_window_set_default_size () #15 0x809ce37 in gtk_signal_connect_object () #16 0x809c4be in gtk_signal_connect_object () #17 0x809abfa in gtk_selection_data_set () #18 0x80bc848 in gtk_widget_size_request () #19 0x808b9b5 in gtk_menu_shell_append () #20 0x808aeb6 in gtk_menu_shell_append () #21 0x80c3fdc in gtk_window_set_default_size () #22 0x809c4eb in gtk_signal_connect_object () #23 0x809abfa in gtk_selection_data_set () #24 0x80bc724 in gtk_widget_size_request () #25 0x8085d79 in gtk_get_current_event () #26 0x808531a in gtk_main_iteration_do () #27 0x80d31ab in gdk_input_add () #28 0x80e6130 in g_list_length () #29 0x80e65ab in g_list_length () #30 0x80e66c5 in g_main_iteration () #31 0x8084e2f in gtk_main () #32 0x4009281b in nsAppShell::Run () #33 0x40018da6 in nsAppShellService::Run () #34 0x8051313 in main () *I've also tagged the incidents with the Bug ID 6885 so that should work also.
I was just reading bug 6885, do you need anymore infor here or are you all set?
This looks like a dup of a bug that just got fixed, so I think we're all set. Thanks.
i meant i was looking at 6823. too many bugs...making me goofy...sorry for the spam
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Target Milestone: M7
So this should work now, so I'm marking as fixed.
Status: RESOLVED → VERIFIED
VERIFIED for WinNT and Linux builds 1999052516
You need to log in before you can comment on or make changes to this bug.