Closed
Bug 6892
Opened 25 years ago
Closed 25 years ago
[PP] the browser window keeps popping up to the front of the window you are using.
Categories
(Core :: Layout, defect, P3)
Core
Layout
Tracking
()
VERIFIED
FIXED
M7
People
(Reporter: esther, Assigned: nisheeth_mozilla)
References
Details
Using 19990520 buids the browser window keeps popping up to the front of the
window you are using.
1. Launch apprunner.
2. Open Editor or Messenger
3. Wait about a minute, you will see the Browser window come up to the front and
have focus.
Just started happening with this build.
Summary: [PP] the browser window keeps popping up to the front of the window you are using. → [PP] the browser window keeps popping up to the front of the window you are using.
Comment 4•25 years ago
|
||
One possibility is that this is happening exactly when the sidebar re-loads
content. Maybe "onload" has default behavior to bring the window to the front?
Try this: sidebar-browser.rdf from mozilla/dist/win32_d.obj/bin/res/rdf (so the
sidebar won't load any content), and see if the problem persists.
Comment 5•25 years ago
|
||
This sidebar loads the Tinderbox panel every minute. Would this cause the
browser to pop to the front?
Updated•25 years ago
|
Assignee: chofmann → waterson
Updated•25 years ago
|
Target Milestone: M6
Updated•25 years ago
|
Assignee: waterson → rickg
Comment 6•25 years ago
|
||
It is the flash panel (or maybe the reload of the tinderbox panel) in the
sidebar that is causing this. However, the problem seems to be that we _always_
call window->SetFocus() when a new webshell gets embedded.
Here is the stack trace.
nsWindow::SetFocus(nsWindow * const 0x04420724) line 900
DocumentViewerImpl::MakeWindow(void * 0x00150a76, const nsRect & {...},
nsScrollPreference nsScrollPreference_kAuto) line 739
DocumentViewerImpl::Init(DocumentViewerImpl * const 0x03fe6e70, void *
0x00150a76, nsIDeviceContext * 0x03ef0400, nsIPref * 0x00ec3890, const nsRect &
{...}, nsScrollPreference nsScrollPreference_kAuto) line 341
nsWebShell::Embed(nsWebShell * const 0x03eefc40, nsIContentViewer * 0x03fe6e70,
char * 0x0463f530, nsISupports * 0x00000000) line 765 + 69 bytes
nsDocumentBindInfo::OnStartBinding(nsDocumentBindInfo * const 0x0463f4e0,
nsIURL * 0x0463f910, char * 0x03fcdb70) line 1428 + 36 bytes
OnStartBindingProxyEvent::HandleEvent(OnStartBindingProxyEvent * const
0x03fcd980) line 507
StreamListenerProxyEvent::HandlePLEvent(PLEvent * 0x03fcd984) line 472 + 12
bytes
PL_HandleEvent(PLEvent * 0x03fcd984) line 491 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x00ee58c0) line 452 + 9 bytes
_md_EventReceiverProc(void * 0x155a0528, unsigned int 0x0000c0a6, unsigned int
0x00000000, long 0x00ee58c0) line 868 + 9 bytes
USER32! 77e71268()
I'd comment it out, but, see comments at:
http://lxr.mozilla.org/seamonkey/source/layout/base/src/nsDocumentViewer.cpp#73
4
Reassigning to rickg to parcel out as appropriate. This is a generic layout
problem. FWIW, it seems that this is fundamentally wrong, and we need to
figure out another way to ensure that page up/page down work. You can't call
SetFocus() every time a document finishes loading, or else you'll end up with
races between documents.
Updated•25 years ago
|
OS: Windows 95 → All
Hardware: PC → All
Comment 10•25 years ago
|
||
adding myself to this bug; changing Platform/OS to ALL since a side effect of the
behavior waterson describes happens on Mac as well (edit field loses focus while
typing in it).
I think the priority should be upped to P2 because it is so difficult to file
bugs in 5.0 when you keep losing focus.
Updated•25 years ago
|
Target Milestone: M6 → M7
Comment 11•25 years ago
|
||
need to move this to M7. we will release note how to
disable the sidebar features that expose this bug.
Comment 12•25 years ago
|
||
Nisheeth -- let's start with the assumption that the webshell call to setfocus()
is the culprit. This is an important bug, so please take a look as soon as you
can.
Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 13•25 years ago
|
||
For now, I am going to comment out the call to SetFocus() within
nsDocumentViewer::MakeWindow(). All the places in the embedding application
which need to set focus on a particular window can call the SetFocus() method on
the webshell corresponding to that window.
Any objections?
Assignee | ||
Comment 14•25 years ago
|
||
Adding rickg and waterson to the cc list so that they can respond to my earlier
comment.
Comment 15•25 years ago
|
||
Makes sense to me.
Assignee | ||
Updated•25 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 16•25 years ago
|
||
The fix was checked in on 6/3. Marking bug resolved.
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
Comment 17•25 years ago
|
||
Fixed in the June 09 Build.
You need to log in
before you can comment on or make changes to this bug.
Description
•