(dormant account) Assignee
	Description • 13 years ago

      No description provided.

	Mike Hommey [:glandium]
	Comment 2 • 13 years ago

Comment on attachment 563572 [details] [diff] [review]
report startupInterrupted

Review of attachment 563572 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/TelemetryPing.js
@@ +195,4 @@
>        ret[field] = si[field] - si.process
>      }
>    }
> +  ret.startupInterrupted = Services.startup.interrupted * 1;

Number(Services.startup.interrupted) would seem less strange.

	(dormant account) Assignee
	Comment 3 • 13 years ago

http://hg.mozilla.org/integration/mozilla-inbound/rev/38ec795c6065

	Marco Bonardo [:mak]
	Comment 4 • 13 years ago

https://hg.mozilla.org/mozilla-central/rev/38ec795c6065

	Jesse Ruderman
	Comment 5 • 13 years ago

Eww. "new Number" creates an unnecessary object. Furthermore, that object behaves in subtly different way from primitive numbers.

A better way to coerce to number is with the unary + operator.

	:Gavin Sharp [email: gavin@gavinsharp.com]
	Comment 6 • 13 years ago

(In reply to Jesse Ruderman from comment #5)
> A better way to coerce to number is with the unary + operator.

I would prefer just removing the "new".