Closed
Bug 690585
Opened 13 years ago
Closed 13 years ago
Report startup interruptions
Categories
(Toolkit :: Telemetry, defect)
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: taras.mozilla, Assigned: taras.mozilla)
References
Details
Attachments
(1 file)
(deleted),
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Comment 2•13 years ago
|
||
Comment on attachment 563572 [details] [diff] [review] report startupInterrupted Review of attachment 563572 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/telemetry/TelemetryPing.js @@ +195,4 @@ > ret[field] = si[field] - si.process > } > } > + ret.startupInterrupted = Services.startup.interrupted * 1; Number(Services.startup.interrupted) would seem less strange.
Attachment #563572 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 3•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/38ec795c6065
Whiteboard: [inbound]
Updated•13 years ago
|
Assignee: nobody → tglek
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/38ec795c6065
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla10
Comment 5•13 years ago
|
||
Eww. "new Number" creates an unnecessary object. Furthermore, that object behaves in subtly different way from primitive numbers. A better way to coerce to number is with the unary + operator.
Comment 6•13 years ago
|
||
(In reply to Jesse Ruderman from comment #5) > A better way to coerce to number is with the unary + operator. I would prefer just removing the "new".
You need to log in
before you can comment on or make changes to this bug.
Description
•