TEST: /testAddons/testDisableEnablePlugin ERROR: controller.waitForEval: Timeout exceeded for 'subject.plugin.getPluginState(subject.node, subject.value) == subject.state' WHEN: 2011-10-07 FIRST: 2011-08-20 BRANCHES: 1.9.2

A Pivotal Tracker story has been created: https://www.pivotaltracker.com/story/show/19393443

This skips the test.

Comment on attachment 565524 [details] [diff] [review] skip test (1.9.2) [checked-in] Looks fine

Comment on attachment 565524 [details] [diff] [review] skip test (1.9.2) [checked-in] Landed: http://hg.mozilla.org/qa/mozmill-tests/rev/c0b27bf636ab (mozilla-1.9.2)

This is for 1.9.2 branch and with the new refactoring we'll drop Mozmill support for 1.9.2 However, waitForEval can be changed with waitFor to fix this test - should we have a fix patch or just close the bug?

(In reply to Maniac Vlad Florin (:vladmaniac) from comment #5) > This is for 1.9.2 branch and with the new refactoring we'll drop Mozmill > support for 1.9.2 What? Who said that we drop support for 1.9.2?

(In reply to Henrik Skupin (:whimboo) from comment #6) > (In reply to Maniac Vlad Florin (:vladmaniac) from comment #5) > > This is for 1.9.2 branch and with the new refactoring we'll drop Mozmill > > support for 1.9.2 > > What? Who said that we drop support for 1.9.2? There was a discussion on the mailing list about it some time ago I'll have to check and get back to you

We are going to drop support only on master so an easy fix would apply here .

Changed waitForEval with waitFor in addons.js on mozilla-1.9.2 branch This was not covered by Remus's refactoring waitFor patch for shared modules. Also, re-enabled the test by deleting the skip lines.

(In reply to Maniac Vlad Florin (:vladmaniac) from comment #9) > This was not covered by Remus's refactoring waitFor patch for shared > modules. We have not landed the patch for shared modules on 1.9.2 yet. So not sure if that would make this patch obsolete later today.

(In reply to Henrik Skupin (:whimboo) from comment #10) > (In reply to Maniac Vlad Florin (:vladmaniac) from comment #9) > > This was not covered by Remus's refactoring waitFor patch for shared > > modules. > > We have not landed the patch for shared modules on 1.9.2 yet. So not sure if > that would make this patch obsolete later today. Can you please clarify this statement Henrik? Does this mean that 1.9.2 does not have access to waitFor() and will not until the Shared Modules refactor patch lands? Thanks

It has but I'm waiting for the backport from Remus. Both patches would be in conflict.

(In reply to Henrik Skupin (:whimboo) from comment #12) > It has but I'm waiting for the backport from Remus. Both patches would be in > conflict. You mean Remus' tests refactor patch or is there a separate patch for shared modules I am unaware of?

Yes, it is bug 714802.

Comment on attachment 588021 [details] [diff] [review] quickfix patch v1.0 (In reply to Henrik Skupin (:whimboo) from comment #14) > Yes, it is bug 714802. Thanks Henrik; adding dependency. Vlad, please retest and renominate for review after the 1.9.2 patch for bug 714802 has landed. Thanks

Since Firefox 3.6 will be EOL soon, resolving this bug WONTFIX.