From Bugzilla Helper: User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; 0.8) Gecko/20010215 BuildID: 2001021508 In the modern theme, when you move the mouse over the second row of menus, "New folder", "New Seperator", "", "Properties",..., you can't tell that you're actually on that menu item. Every other menu I've found like this in Mozilla has some indication. Reproducible: Always Steps to Reproduce: 1) Open Manage Bookmarks 2) Move mouse over any any item on second row of menus Actual Results: Nothing Expected Results: There should be some signal to the user that clicking the mouse here will select that menu item (item gets brighter, box around item is raised, etc.

-> Themes

-> hewitt

Confirming this with user agent: Mozilla/5.0 (Windows; U; Win98; en-US; 0.8) Gecko/20010217 build: 2001021708 This bug may be an extension (duplicate?) of bug 68548 but I'm not sure.

That's correct Janzert, the modern skin currently doesn't have rules for the toolbar. Marking dependant on bug 68548.

I'm working on this one right now...

hewitt, any progress on this?

Themes Triage Team marking nsbeta1+ and 0.9

In addition to the known flaws in the bookmarks window using the modern theme, I've found several imperfections in the classic theme as well. So, I'm expanding this bug to cover both themes. It's all fixed in my tree, so patch coming soon.

The non-modern-specific problems that I fixed are as follows: 1. toolbar buttons in bookmarks.xul should be button-toolbar, not button-toolbar-2 2. the File menubutton should use bookmarkfolder on each menuitem, not treeitem-bookmark, which is why they are missing icons 3. delay-click-editing on treecells wasn't working due to a minor glitch in bookmarksTree.js 4. in the classic theme, the alignment of editable-treecells was a bit off

I talked with joe on IRC about better factoring of the style rules here to create a generic .bookmarkitem class, ditching .treeitem-bookmark and .bookmarkfolder, and sharing all these rules between the tree, the menu and the personal toolbar. With these discussed mods, a=ben@netscape.com

sounds good, but i don't think i can r= it w/o seeing it.

I need an r= for this one to check it in. Beware, it's a big nasty patch.

blake sez r=blake, ben sez sr=ben

fixed

Marking verified on windows 98 (2001-03-26-09-Mtrunk).